Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance on UI for user agent implementations #26

Open
joshtriplett opened this issue Aug 23, 2018 · 2 comments
Open

Provide guidance on UI for user agent implementations #26

joshtriplett opened this issue Aug 23, 2018 · 2 comments

Comments

@joshtriplett
Copy link

Given the ability to select a directory and upload it in its entirety, I can imagine a malicious site saying something like "please choose a directory to save your X in" or similar, and using that to lead a user into uploading their home directory or download folder.

Please consider including a "UI security considerations and guidelines for user agents" or similar, documenting potential threat models like that, and suggesting approaches such as making the file upload UI show a preview of the number of files that will be uploaded and the first few filenames, very explicitly using language that makes it clear the files will be sent to the site, and identifying the site.

@inexorabletash
Copy link
Collaborator

That sounds good. Want to write something up? PRs welcome!

(Since this document was describing reality rather than proposing something I didn't spent time on the niceties like a Security & Privacy section, but it should be added)

@inexorabletash
Copy link
Collaborator

Note that Chrome now shows an alert after selection, something like "You have selected 123 files to upload. Are you sure?" as a mitigation for the "upload your home directory" problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants