Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS a user, the bot should error out if I supply an invalid sortBy value #45

Open
3 tasks
Vylpes opened this issue Sep 14, 2023 · 1 comment
Open
3 tasks
Labels
Milestone

Comments

@Vylpes
Copy link
Owner

Vylpes commented Sep 14, 2023

AS a user, the bot should error out if I supply an invalid sortBy value
SO THAT I know if I'm using an incorrect value

Acceptance Criteria

AS a user
GIVEN I supply a value to sortBy which isn't valid
WHEN I run the function
THEN an error should be returned

Subtasks

  • Add error check
  • Add typescript string types
  • Update tests
@Vylpes Vylpes changed the title Defining an invalid sortBy value should error AS a user, the bot should error out if I supply an invalid sortBy value Oct 24, 2023
@Vylpes
Copy link
Owner Author

Vylpes commented Oct 24, 2023

We should also update the typescript to only allow the values in it for further validation

@Vylpes Vylpes added this to the 2.2 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant