From 2a904817f7f9298ea73cc6e5783de11d09a8ec57 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Wed, 1 Jan 2020 16:03:05 -0500 Subject: [PATCH] Revert "Support if the help is either stdout or stderr (#64)" This reverts commit 187a7742892088cfa7d90afde2387882028b16b2. Cobra has reverted the change that had the help message go to stderr: https://github.com/spf13/cobra/pull/1004 Considering what allowed to notice this regression in Cobra was the failure of Helm's acceptance-testing repo, I prefer to continue have the test fail if the help ever goes to stderr. --- scripts/completion-tests/completionTests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/completion-tests/completionTests.sh b/scripts/completion-tests/completionTests.sh index b616ff2..46e66df 100755 --- a/scripts/completion-tests/completionTests.sh +++ b/scripts/completion-tests/completionTests.sh @@ -242,7 +242,7 @@ if [ ! -z ${ROBOT_HELM_V3} ]; then # Also test that the list of outputs matches what the helm message gives. # This is an imperfect way of detecting if the output format list has changed, but # the completion wasn't updated to match. - outputFormats=$(helm repo list -h 2>&1 | grep -- --output | cut -d: -f2 | cut -d '(' -f1 | sed s/,//g) + outputFormats=$(helm repo list -h | grep -- --output | cut -d: -f2 | cut -d '(' -f1 | sed s/,//g) _completionTests_verifyCompletion "helm repo list --output " "${outputFormats}" _completionTests_verifyCompletion "helm install --output " "${outputFormats}" _completionTests_verifyCompletion "helm history -o " "${outputFormats}"