Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: very_good_flutter_plugin doesn't have full code coverage #40

Closed
2 tasks
alestiago opened this issue Feb 23, 2024 · 3 comments · Fixed by #117
Closed
2 tasks

test: very_good_flutter_plugin doesn't have full code coverage #40

alestiago opened this issue Feb 23, 2024 · 3 comments · Fixed by #117
Assignees
@wolfenrain @alestiago
Labels
good first issue Good for newcomers p1 High-priority issues at the top of the work list product: very_good_flutter_plugin Changes that affect the Very Good Flutter Plugin template. test Changes that add missing tests or correcting existing tests

Comments

@alestiago
Copy link
Contributor

alestiago commented Feb 23, 2024 •
edited

Description

The coverage of the template is not 100%, it's 86%.

Reproductive steps

  1. Get the Very Good Flutter Plugin brick (from .):
mason get
  1. Generate Very Good Flutter Plugin (from .):
mason make very_good_flutter_plugin -o output/
  1. Run tests (from output/):
very_good test -j 4 --recursive --optimization --coverage --test-randomize-ordering-seed random --min-coverage 100

Expected behaviour

Coverage should be 100%

Requirements

  • Coverage should be 100%
  • Update workflow to check coverage is 100%
@alestiago alestiago added needs triage Issue requires triage test Changes that add missing tests or correcting existing tests product: very_good_flutter_plugin Changes that affect the Very Good Flutter Plugin template. labels Feb 23, 2024
@alestiago alestiago mentioned this issue Feb 23, 2024
Closed
1 task
@tomarra tomarra added good first issue Good for newcomers p1 High-priority issues at the top of the work list and removed needs triage Issue requires triage labels Mar 11, 2024
@tomarra
Copy link
Contributor

tomarra commented Mar 25, 2024

Assigning to @wolfenrain given that it has to do with Fluttium.

@wolfenrain wolfenrain mentioned this issue Apr 4, 2024
Merged
7 tasks
@alestiago
Copy link
Contributor Author

Closed by #89

@alestiago
Copy link
Contributor Author

alestiago commented May 23, 2024 •
edited

Re-opening until we check again for 100% coverage on CI:

very_good_templates/.github/workflows/very_good_flutter_plugin.yaml

Line 86 in f7e6c45

min_coverage: 86

@alestiago alestiago reopened this May 23, 2024
@alestiago alestiago self-assigned this May 28, 2024
@alestiago alestiago mentioned this issue May 28, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfenrain wolfenrain

@alestiago alestiago

Labels
good first issue Good for newcomers p1 High-priority issues at the top of the work list product: very_good_flutter_plugin Changes that affect the Very Good Flutter Plugin template. test Changes that add missing tests or correcting existing tests
Projects
VGV Open Source 🦄 🧙🌟
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(very_good_flutter_plugin): check for full test coverage VeryGoodOpenSource/very_good_templates
3 participants
@tomarra @wolfenrain @alestiago