Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw "lcov is empty" instead of "parsing error!" #104

Merged
merged 5 commits into from Feb 8, 2022
Merged

fix: throw "lcov is empty" instead of "parsing error!" #104

merged 5 commits into from Feb 8, 2022

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Feb 3, 2022 •
edited

Description

Throws a "lcov is empty!" error message instead of "parsing error!" when the coverage file is empty. Attempts to resolve #95.

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

felangel
felangel approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@felangel felangel merged commit 49de719 into VeryGoodOpenSource:main Feb 8, 2022
@alestiago alestiago deleted the fix/empty-or-missing-error branch February 10, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parsing error!
2 participants
@alestiago @felangel