Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file-report disables optimization #1009

Open
DFelten opened this issue Apr 5, 2024 · 1 comment
Open

fix: file-report disables optimization #1009

DFelten opened this issue Apr 5, 2024 · 1 comment
Labels
bug Something isn't working as expected has reproductive steps This issue contains detailed steps to reproduce the issue waiting for response Waiting for follow up

Comments

@DFelten
Copy link

DFelten commented Apr 5, 2024

Description

It is now possible to start the tests with an output as mentioned here. But when running a test with very_good and the file-reporter parameter, the parameter for optimization is no longer working.

Steps To Reproduce

Run test via

very_good test --optimization --coverage -- --file-reporter json:test_reports/dd_test_report.json

No test optimization appears in the terminal and the test needs four times as long. The .test_optimizer.dart file is not generated while the test is running.

Expected Behavior

The test should run with optimization and create a report.

Screenshots

CleanShot 2024-04-05 at 09 59 04@2x

@DFelten DFelten added the bug Something isn't working as expected label Apr 5, 2024
@alestiago alestiago added the has reproductive steps This issue contains detailed steps to reproduce the issue label May 16, 2024
@alestiago
Copy link
Contributor

Hi @DFelten ! Thank you for opening an issue sorry for the late reply, I've haven't been able to catch-up lately.

I've been able to reproduce this in the latest very_good_cli (0.21.0). @DFelten are you interested in contributing?

@alestiago alestiago added the waiting for response Waiting for follow up label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected has reproductive steps This issue contains detailed steps to reproduce the issue waiting for response Waiting for follow up
Projects
Status: Needs Triage
Development

No branches or pull requests

2 participants