From 8cd941d5873382ba6751480142e2fe8772d6cf33 Mon Sep 17 00:00:00 2001 From: Lucas Date: Fri, 22 Jul 2022 22:31:15 +0200 Subject: [PATCH 1/8] feat: v3.0.2 --- lib/analysis_options.3.0.2.yaml | 196 ++++++++++++++++++++++++++++++++ lib/analysis_options.yaml | 2 +- 2 files changed, 197 insertions(+), 1 deletion(-) create mode 100644 lib/analysis_options.3.0.2.yaml diff --git a/lib/analysis_options.3.0.2.yaml b/lib/analysis_options.3.0.2.yaml new file mode 100644 index 0000000..92e168c --- /dev/null +++ b/lib/analysis_options.3.0.2.yaml @@ -0,0 +1,196 @@ +analyzer: + language: + strict-casts: true + strict-inference: true + strict-raw-types: true + + errors: + close_sinks: ignore + missing_required_param: error + missing_return: error + + exclude: + - test/.test_coverage.dart + - lib/generated_plugin_registrant.dart + +linter: + rules: + - always_declare_return_types + - always_require_non_null_named_parameters + - always_use_package_imports + - annotate_overrides + - avoid_bool_literals_in_conditional_expressions + - avoid_catching_errors + - avoid_double_and_int_checks + - avoid_dynamic_calls + - avoid_empty_else + - avoid_equals_and_hash_code_on_mutable_classes + - avoid_escaping_inner_quotes + - avoid_field_initializers_in_const_classes + - avoid_function_literals_in_foreach_calls + - avoid_init_to_null + - avoid_js_rounded_ints + - avoid_null_checks_in_equality_operators + - avoid_positional_boolean_parameters + - avoid_print + - avoid_private_typedef_functions + - avoid_redundant_argument_values + - avoid_relative_lib_imports + - avoid_renaming_method_parameters + - avoid_return_types_on_setters + - avoid_returning_null + - avoid_returning_null_for_future + - avoid_returning_null_for_void + - avoid_returning_this + - avoid_setters_without_getters + - avoid_shadowing_type_parameters + - avoid_single_cascade_in_expression_statements + - avoid_slow_async_io + - avoid_type_to_string + - avoid_types_as_parameter_names + - avoid_unnecessary_containers + - avoid_unused_constructor_parameters + - avoid_void_async + - avoid_web_libraries_in_flutter + - await_only_futures + - camel_case_extensions + - camel_case_types + - cancel_subscriptions + - cascade_invocations + - cast_nullable_to_non_nullable + - comment_references + - conditional_uri_does_not_exist + - constant_identifier_names + - control_flow_in_finally + - curly_braces_in_flow_control_structures + - depend_on_referenced_packages + - deprecated_consistency + - directives_ordering + - empty_catches + - empty_constructor_bodies + - empty_statements + - eol_at_end_of_file + - exhaustive_cases + - file_names + - flutter_style_todos + - hash_and_equals + - implementation_imports + - iterable_contains_unrelated_type + - join_return_with_assignment + - leading_newlines_in_multiline_strings + - library_names + - library_prefixes + - library_private_types_in_public_api + - lines_longer_than_80_chars + - list_remove_unrelated_type + - literal_only_boolean_expressions + - missing_whitespace_between_adjacent_strings + - no_adjacent_strings_in_list + - no_default_cases + - no_duplicate_case_values + - no_leading_underscores_for_library_prefixes + - no_leading_underscores_for_local_identifiers + - no_logic_in_create_state + - no_runtimeType_toString + - non_constant_identifier_names + - noop_primitive_operations + - null_check_on_nullable_type_parameter + - null_closures + - omit_local_variable_types + - one_member_abstracts + - only_throw_errors + - overridden_fields + - package_api_docs + - package_names + - package_prefixed_library_names + - parameter_assignments + - prefer_adjacent_string_concatenation + - prefer_asserts_in_initializer_lists + - prefer_asserts_with_message + - prefer_collection_literals + - prefer_conditional_assignment + - prefer_const_constructors + - prefer_const_constructors_in_immutables + - prefer_const_declarations + - prefer_const_literals_to_create_immutables + - prefer_constructors_over_static_methods + - prefer_contains + - prefer_equal_for_default_values + - prefer_final_fields + - prefer_final_in_for_each + - prefer_final_locals + - prefer_for_elements_to_map_fromIterable + - prefer_function_declarations_over_variables + - prefer_generic_function_type_aliases + - prefer_if_elements_to_conditional_expressions + - prefer_if_null_operators + - prefer_initializing_formals + - prefer_inlined_adds + - prefer_int_literals + - prefer_interpolation_to_compose_strings + - prefer_is_empty + - prefer_is_not_empty + - prefer_is_not_operator + - prefer_iterable_whereType + - prefer_null_aware_method_calls + - prefer_null_aware_operators + - prefer_single_quotes + - prefer_spread_collections + - prefer_typing_uninitialized_variables + - prefer_void_to_null + - provide_deprecation_message + - public_member_api_docs + - recursive_getters + - require_trailing_commas + - secure_pubspec_urls + - sized_box_for_whitespace + - sized_box_shrink_expand + - slash_for_doc_comments + - sort_child_properties_last + - sort_constructors_first + - sort_pub_dependencies + - sort_unnamed_constructors_first + - test_types_in_equals + - throw_in_finally + - tighten_type_of_initializing_formals + - type_annotate_public_apis + - type_init_formals + - unawaited_futures + - unnecessary_await_in_return + - unnecessary_brace_in_string_interps + - unnecessary_const + - unnecessary_constructor_name + - unnecessary_getters_setters + - unnecessary_lambdas + - unnecessary_late + - unnecessary_new + - unnecessary_null_aware_assignments + - unnecessary_null_checks + - unnecessary_null_in_if_null_operators + - unnecessary_nullable_for_final_variable_declarations + - unnecessary_overrides + - unnecessary_parenthesis + - unnecessary_raw_strings + - unnecessary_statements + - unnecessary_string_escapes + - unnecessary_string_interpolations + - unnecessary_this + - unrelated_type_equality_checks + - use_build_context_synchronously + - use_colored_box + - use_decorated_box + - use_enums + - use_full_hex_values_for_flutter_colors + - use_function_type_syntax_for_parameters + - use_is_even_rather_than_modulo + - use_key_in_widget_constructors + - use_late_for_private_fields_and_variables + - use_named_constants + - use_raw_strings + - use_rethrow_when_possible + - use_setters_to_change_properties + - use_string_buffers + - use_super_parameters + - use_to_and_as_if_applicable + - valid_regexps + - void_checks diff --git a/lib/analysis_options.yaml b/lib/analysis_options.yaml index d0fffaf..3e5b717 100644 --- a/lib/analysis_options.yaml +++ b/lib/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.3.0.1.yaml +include: package:very_good_analysis/analysis_options.3.0.2.yaml From d1ebc130296390608f8157d55c9db907c0ea17fd Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Thu, 8 Sep 2022 14:35:10 -0500 Subject: [PATCH 2/8] apply changes inline --- lib/analysis_options.3.0.1.yaml | 4 +- lib/analysis_options.3.0.2.yaml | 196 -------------------------------- lib/analysis_options.yaml | 2 +- 3 files changed, 4 insertions(+), 198 deletions(-) delete mode 100644 lib/analysis_options.3.0.2.yaml diff --git a/lib/analysis_options.3.0.1.yaml b/lib/analysis_options.3.0.1.yaml index 11aa45b..92e168c 100644 --- a/lib/analysis_options.3.0.1.yaml +++ b/lib/analysis_options.3.0.1.yaml @@ -63,6 +63,7 @@ linter: - constant_identifier_names - control_flow_in_finally - curly_braces_in_flow_control_structures + - depend_on_referenced_packages - deprecated_consistency - directives_ordering - empty_catches @@ -74,7 +75,6 @@ linter: - flutter_style_todos - hash_and_equals - implementation_imports - - invariant_booleans - iterable_contains_unrelated_type - join_return_with_assignment - leading_newlines_in_multiline_strings @@ -88,6 +88,8 @@ linter: - no_adjacent_strings_in_list - no_default_cases - no_duplicate_case_values + - no_leading_underscores_for_library_prefixes + - no_leading_underscores_for_local_identifiers - no_logic_in_create_state - no_runtimeType_toString - non_constant_identifier_names diff --git a/lib/analysis_options.3.0.2.yaml b/lib/analysis_options.3.0.2.yaml deleted file mode 100644 index 92e168c..0000000 --- a/lib/analysis_options.3.0.2.yaml +++ /dev/null @@ -1,196 +0,0 @@ -analyzer: - language: - strict-casts: true - strict-inference: true - strict-raw-types: true - - errors: - close_sinks: ignore - missing_required_param: error - missing_return: error - - exclude: - - test/.test_coverage.dart - - lib/generated_plugin_registrant.dart - -linter: - rules: - - always_declare_return_types - - always_require_non_null_named_parameters - - always_use_package_imports - - annotate_overrides - - avoid_bool_literals_in_conditional_expressions - - avoid_catching_errors - - avoid_double_and_int_checks - - avoid_dynamic_calls - - avoid_empty_else - - avoid_equals_and_hash_code_on_mutable_classes - - avoid_escaping_inner_quotes - - avoid_field_initializers_in_const_classes - - avoid_function_literals_in_foreach_calls - - avoid_init_to_null - - avoid_js_rounded_ints - - avoid_null_checks_in_equality_operators - - avoid_positional_boolean_parameters - - avoid_print - - avoid_private_typedef_functions - - avoid_redundant_argument_values - - avoid_relative_lib_imports - - avoid_renaming_method_parameters - - avoid_return_types_on_setters - - avoid_returning_null - - avoid_returning_null_for_future - - avoid_returning_null_for_void - - avoid_returning_this - - avoid_setters_without_getters - - avoid_shadowing_type_parameters - - avoid_single_cascade_in_expression_statements - - avoid_slow_async_io - - avoid_type_to_string - - avoid_types_as_parameter_names - - avoid_unnecessary_containers - - avoid_unused_constructor_parameters - - avoid_void_async - - avoid_web_libraries_in_flutter - - await_only_futures - - camel_case_extensions - - camel_case_types - - cancel_subscriptions - - cascade_invocations - - cast_nullable_to_non_nullable - - comment_references - - conditional_uri_does_not_exist - - constant_identifier_names - - control_flow_in_finally - - curly_braces_in_flow_control_structures - - depend_on_referenced_packages - - deprecated_consistency - - directives_ordering - - empty_catches - - empty_constructor_bodies - - empty_statements - - eol_at_end_of_file - - exhaustive_cases - - file_names - - flutter_style_todos - - hash_and_equals - - implementation_imports - - iterable_contains_unrelated_type - - join_return_with_assignment - - leading_newlines_in_multiline_strings - - library_names - - library_prefixes - - library_private_types_in_public_api - - lines_longer_than_80_chars - - list_remove_unrelated_type - - literal_only_boolean_expressions - - missing_whitespace_between_adjacent_strings - - no_adjacent_strings_in_list - - no_default_cases - - no_duplicate_case_values - - no_leading_underscores_for_library_prefixes - - no_leading_underscores_for_local_identifiers - - no_logic_in_create_state - - no_runtimeType_toString - - non_constant_identifier_names - - noop_primitive_operations - - null_check_on_nullable_type_parameter - - null_closures - - omit_local_variable_types - - one_member_abstracts - - only_throw_errors - - overridden_fields - - package_api_docs - - package_names - - package_prefixed_library_names - - parameter_assignments - - prefer_adjacent_string_concatenation - - prefer_asserts_in_initializer_lists - - prefer_asserts_with_message - - prefer_collection_literals - - prefer_conditional_assignment - - prefer_const_constructors - - prefer_const_constructors_in_immutables - - prefer_const_declarations - - prefer_const_literals_to_create_immutables - - prefer_constructors_over_static_methods - - prefer_contains - - prefer_equal_for_default_values - - prefer_final_fields - - prefer_final_in_for_each - - prefer_final_locals - - prefer_for_elements_to_map_fromIterable - - prefer_function_declarations_over_variables - - prefer_generic_function_type_aliases - - prefer_if_elements_to_conditional_expressions - - prefer_if_null_operators - - prefer_initializing_formals - - prefer_inlined_adds - - prefer_int_literals - - prefer_interpolation_to_compose_strings - - prefer_is_empty - - prefer_is_not_empty - - prefer_is_not_operator - - prefer_iterable_whereType - - prefer_null_aware_method_calls - - prefer_null_aware_operators - - prefer_single_quotes - - prefer_spread_collections - - prefer_typing_uninitialized_variables - - prefer_void_to_null - - provide_deprecation_message - - public_member_api_docs - - recursive_getters - - require_trailing_commas - - secure_pubspec_urls - - sized_box_for_whitespace - - sized_box_shrink_expand - - slash_for_doc_comments - - sort_child_properties_last - - sort_constructors_first - - sort_pub_dependencies - - sort_unnamed_constructors_first - - test_types_in_equals - - throw_in_finally - - tighten_type_of_initializing_formals - - type_annotate_public_apis - - type_init_formals - - unawaited_futures - - unnecessary_await_in_return - - unnecessary_brace_in_string_interps - - unnecessary_const - - unnecessary_constructor_name - - unnecessary_getters_setters - - unnecessary_lambdas - - unnecessary_late - - unnecessary_new - - unnecessary_null_aware_assignments - - unnecessary_null_checks - - unnecessary_null_in_if_null_operators - - unnecessary_nullable_for_final_variable_declarations - - unnecessary_overrides - - unnecessary_parenthesis - - unnecessary_raw_strings - - unnecessary_statements - - unnecessary_string_escapes - - unnecessary_string_interpolations - - unnecessary_this - - unrelated_type_equality_checks - - use_build_context_synchronously - - use_colored_box - - use_decorated_box - - use_enums - - use_full_hex_values_for_flutter_colors - - use_function_type_syntax_for_parameters - - use_is_even_rather_than_modulo - - use_key_in_widget_constructors - - use_late_for_private_fields_and_variables - - use_named_constants - - use_raw_strings - - use_rethrow_when_possible - - use_setters_to_change_properties - - use_string_buffers - - use_super_parameters - - use_to_and_as_if_applicable - - valid_regexps - - void_checks diff --git a/lib/analysis_options.yaml b/lib/analysis_options.yaml index 3e5b717..d0fffaf 100644 --- a/lib/analysis_options.yaml +++ b/lib/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.3.0.2.yaml +include: package:very_good_analysis/analysis_options.3.0.1.yaml From 62c61bf0aa39a64235fd4dda71fad743455aa088 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Thu, 8 Sep 2022 14:42:38 -0500 Subject: [PATCH 3/8] revert --- lib/analysis_options.3.0.1.yaml | 4 +- lib/analysis_options.3.0.2.yaml | 196 ++++++++++++++++++++++++++++++++ lib/analysis_options.yaml | 2 +- 3 files changed, 198 insertions(+), 4 deletions(-) create mode 100644 lib/analysis_options.3.0.2.yaml diff --git a/lib/analysis_options.3.0.1.yaml b/lib/analysis_options.3.0.1.yaml index 92e168c..11aa45b 100644 --- a/lib/analysis_options.3.0.1.yaml +++ b/lib/analysis_options.3.0.1.yaml @@ -63,7 +63,6 @@ linter: - constant_identifier_names - control_flow_in_finally - curly_braces_in_flow_control_structures - - depend_on_referenced_packages - deprecated_consistency - directives_ordering - empty_catches @@ -75,6 +74,7 @@ linter: - flutter_style_todos - hash_and_equals - implementation_imports + - invariant_booleans - iterable_contains_unrelated_type - join_return_with_assignment - leading_newlines_in_multiline_strings @@ -88,8 +88,6 @@ linter: - no_adjacent_strings_in_list - no_default_cases - no_duplicate_case_values - - no_leading_underscores_for_library_prefixes - - no_leading_underscores_for_local_identifiers - no_logic_in_create_state - no_runtimeType_toString - non_constant_identifier_names diff --git a/lib/analysis_options.3.0.2.yaml b/lib/analysis_options.3.0.2.yaml new file mode 100644 index 0000000..92e168c --- /dev/null +++ b/lib/analysis_options.3.0.2.yaml @@ -0,0 +1,196 @@ +analyzer: + language: + strict-casts: true + strict-inference: true + strict-raw-types: true + + errors: + close_sinks: ignore + missing_required_param: error + missing_return: error + + exclude: + - test/.test_coverage.dart + - lib/generated_plugin_registrant.dart + +linter: + rules: + - always_declare_return_types + - always_require_non_null_named_parameters + - always_use_package_imports + - annotate_overrides + - avoid_bool_literals_in_conditional_expressions + - avoid_catching_errors + - avoid_double_and_int_checks + - avoid_dynamic_calls + - avoid_empty_else + - avoid_equals_and_hash_code_on_mutable_classes + - avoid_escaping_inner_quotes + - avoid_field_initializers_in_const_classes + - avoid_function_literals_in_foreach_calls + - avoid_init_to_null + - avoid_js_rounded_ints + - avoid_null_checks_in_equality_operators + - avoid_positional_boolean_parameters + - avoid_print + - avoid_private_typedef_functions + - avoid_redundant_argument_values + - avoid_relative_lib_imports + - avoid_renaming_method_parameters + - avoid_return_types_on_setters + - avoid_returning_null + - avoid_returning_null_for_future + - avoid_returning_null_for_void + - avoid_returning_this + - avoid_setters_without_getters + - avoid_shadowing_type_parameters + - avoid_single_cascade_in_expression_statements + - avoid_slow_async_io + - avoid_type_to_string + - avoid_types_as_parameter_names + - avoid_unnecessary_containers + - avoid_unused_constructor_parameters + - avoid_void_async + - avoid_web_libraries_in_flutter + - await_only_futures + - camel_case_extensions + - camel_case_types + - cancel_subscriptions + - cascade_invocations + - cast_nullable_to_non_nullable + - comment_references + - conditional_uri_does_not_exist + - constant_identifier_names + - control_flow_in_finally + - curly_braces_in_flow_control_structures + - depend_on_referenced_packages + - deprecated_consistency + - directives_ordering + - empty_catches + - empty_constructor_bodies + - empty_statements + - eol_at_end_of_file + - exhaustive_cases + - file_names + - flutter_style_todos + - hash_and_equals + - implementation_imports + - iterable_contains_unrelated_type + - join_return_with_assignment + - leading_newlines_in_multiline_strings + - library_names + - library_prefixes + - library_private_types_in_public_api + - lines_longer_than_80_chars + - list_remove_unrelated_type + - literal_only_boolean_expressions + - missing_whitespace_between_adjacent_strings + - no_adjacent_strings_in_list + - no_default_cases + - no_duplicate_case_values + - no_leading_underscores_for_library_prefixes + - no_leading_underscores_for_local_identifiers + - no_logic_in_create_state + - no_runtimeType_toString + - non_constant_identifier_names + - noop_primitive_operations + - null_check_on_nullable_type_parameter + - null_closures + - omit_local_variable_types + - one_member_abstracts + - only_throw_errors + - overridden_fields + - package_api_docs + - package_names + - package_prefixed_library_names + - parameter_assignments + - prefer_adjacent_string_concatenation + - prefer_asserts_in_initializer_lists + - prefer_asserts_with_message + - prefer_collection_literals + - prefer_conditional_assignment + - prefer_const_constructors + - prefer_const_constructors_in_immutables + - prefer_const_declarations + - prefer_const_literals_to_create_immutables + - prefer_constructors_over_static_methods + - prefer_contains + - prefer_equal_for_default_values + - prefer_final_fields + - prefer_final_in_for_each + - prefer_final_locals + - prefer_for_elements_to_map_fromIterable + - prefer_function_declarations_over_variables + - prefer_generic_function_type_aliases + - prefer_if_elements_to_conditional_expressions + - prefer_if_null_operators + - prefer_initializing_formals + - prefer_inlined_adds + - prefer_int_literals + - prefer_interpolation_to_compose_strings + - prefer_is_empty + - prefer_is_not_empty + - prefer_is_not_operator + - prefer_iterable_whereType + - prefer_null_aware_method_calls + - prefer_null_aware_operators + - prefer_single_quotes + - prefer_spread_collections + - prefer_typing_uninitialized_variables + - prefer_void_to_null + - provide_deprecation_message + - public_member_api_docs + - recursive_getters + - require_trailing_commas + - secure_pubspec_urls + - sized_box_for_whitespace + - sized_box_shrink_expand + - slash_for_doc_comments + - sort_child_properties_last + - sort_constructors_first + - sort_pub_dependencies + - sort_unnamed_constructors_first + - test_types_in_equals + - throw_in_finally + - tighten_type_of_initializing_formals + - type_annotate_public_apis + - type_init_formals + - unawaited_futures + - unnecessary_await_in_return + - unnecessary_brace_in_string_interps + - unnecessary_const + - unnecessary_constructor_name + - unnecessary_getters_setters + - unnecessary_lambdas + - unnecessary_late + - unnecessary_new + - unnecessary_null_aware_assignments + - unnecessary_null_checks + - unnecessary_null_in_if_null_operators + - unnecessary_nullable_for_final_variable_declarations + - unnecessary_overrides + - unnecessary_parenthesis + - unnecessary_raw_strings + - unnecessary_statements + - unnecessary_string_escapes + - unnecessary_string_interpolations + - unnecessary_this + - unrelated_type_equality_checks + - use_build_context_synchronously + - use_colored_box + - use_decorated_box + - use_enums + - use_full_hex_values_for_flutter_colors + - use_function_type_syntax_for_parameters + - use_is_even_rather_than_modulo + - use_key_in_widget_constructors + - use_late_for_private_fields_and_variables + - use_named_constants + - use_raw_strings + - use_rethrow_when_possible + - use_setters_to_change_properties + - use_string_buffers + - use_super_parameters + - use_to_and_as_if_applicable + - valid_regexps + - void_checks diff --git a/lib/analysis_options.yaml b/lib/analysis_options.yaml index d0fffaf..3e5b717 100644 --- a/lib/analysis_options.yaml +++ b/lib/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.3.0.1.yaml +include: package:very_good_analysis/analysis_options.3.0.2.yaml From 545c1794188f87fee51fb30e0e9434e7103735eb Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Wed, 14 Sep 2022 16:35:49 -0500 Subject: [PATCH 4/8] chore: v3.1.0 --- CHANGELOG.md | 18 +++ example/pubspec.yaml | 2 +- lib/analysis_options.3.0.2.yaml | 3 - lib/analysis_options.3.1.0.yaml | 207 ++++++++++++++++++++++++++++++++ lib/analysis_options.yaml | 2 +- lib/very_good_analysis.dart | 10 -- pubspec.yaml | 4 +- 7 files changed, 229 insertions(+), 17 deletions(-) create mode 100644 lib/analysis_options.3.1.0.yaml diff --git a/CHANGELOG.md b/CHANGELOG.md index aee64d6..95f0349 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,21 @@ +# 3.1.0 + +- feat: additional lint rules: + - [avoid_final_parameters](https://dart-lang.github.io/linter/lints/avoid_final_parameters.html) + - [avoid_implementing_value_types](https://dart-lang.github.io/linter/lints/avoid_implementing_value_types.html) + - [avoid_multiple_declarations_per_line](https://dart-lang.github.io/linter/lints/avoid_multiple_declarations_per_line.html) + - [avoid_types_on_closure_parameters](https://dart-lang.github.io/linter/lints/avoid_types_on_closure_parameters.html) + - [combinators_ordering](https://dart-lang.github.io/linter/lints/combinators_ordering.html) + - [depend_on_referenced_packages](https://dart-lang.github.io/linter/lints/depend_on_referenced_packages.html) + - [discarded_futures](https://dart-lang.github.io/linter/lints/discarded_futures.html) + - [no_leading_underscores_for_library_prefixes](https://dart-lang.github.io/linter/lints/no_leading_underscores_for_library_prefixes.html) + - [no_leading_underscores_for_local_identifiers](https://dart-lang.github.io/linter/lints/no_leading_underscores_for_local_identifiers.html) + - [unnecessary_to_list_in_spreads](https://dart-lang.github.io/linter/lints/unnecessary_to_list_in_spreads.html) + - [unsafe_html](https://dart-lang.github.io/linter/lints/unsafe_html.html) + - [use_if_null_to_convert_nulls_to_bools](https://dart-lang.github.io/linter/lints/use_if_null_to_convert_nulls_to_bools.html) + - [use_string_in_part_of_directives](https://dart-lang.github.io/linter/lints/use_string_in_part_of_directives.html) + - [use_test_throws_matchers](https://dart-lang.github.io/linter/lints/use_test_throws_matchers.html) + # 3.0.2 - fix: remove deprecated `invariant_booleans` lint diff --git a/example/pubspec.yaml b/example/pubspec.yaml index dc8db90..304a70b 100644 --- a/example/pubspec.yaml +++ b/example/pubspec.yaml @@ -3,7 +3,7 @@ version: 0.0.1 publish_to: none environment: - sdk: ">=2.17.0 <3.0.0" + sdk: ">=2.18.0 <3.0.0" dependencies: very_good_analysis: diff --git a/lib/analysis_options.3.0.2.yaml b/lib/analysis_options.3.0.2.yaml index 92e168c..28ac0ba 100644 --- a/lib/analysis_options.3.0.2.yaml +++ b/lib/analysis_options.3.0.2.yaml @@ -63,7 +63,6 @@ linter: - constant_identifier_names - control_flow_in_finally - curly_braces_in_flow_control_structures - - depend_on_referenced_packages - deprecated_consistency - directives_ordering - empty_catches @@ -88,8 +87,6 @@ linter: - no_adjacent_strings_in_list - no_default_cases - no_duplicate_case_values - - no_leading_underscores_for_library_prefixes - - no_leading_underscores_for_local_identifiers - no_logic_in_create_state - no_runtimeType_toString - non_constant_identifier_names diff --git a/lib/analysis_options.3.1.0.yaml b/lib/analysis_options.3.1.0.yaml new file mode 100644 index 0000000..703df08 --- /dev/null +++ b/lib/analysis_options.3.1.0.yaml @@ -0,0 +1,207 @@ +analyzer: + language: + strict-casts: true + strict-inference: true + strict-raw-types: true + + errors: + close_sinks: ignore + missing_required_param: error + missing_return: error + + exclude: + - test/.test_coverage.dart + - lib/generated_plugin_registrant.dart + +linter: + rules: + - always_declare_return_types + - always_require_non_null_named_parameters + - always_use_package_imports + - annotate_overrides + - avoid_bool_literals_in_conditional_expressions + - avoid_catching_errors + - avoid_double_and_int_checks + - avoid_dynamic_calls + - avoid_empty_else + - avoid_equals_and_hash_code_on_mutable_classes + - avoid_escaping_inner_quotes + - avoid_field_initializers_in_const_classes + - avoid_final_parameters # NEW + - avoid_function_literals_in_foreach_calls + - avoid_implementing_value_types # NEW + - avoid_init_to_null + - avoid_js_rounded_ints + - avoid_multiple_declarations_per_line # NEW + - avoid_null_checks_in_equality_operators + - avoid_positional_boolean_parameters + - avoid_print + - avoid_private_typedef_functions + - avoid_redundant_argument_values + - avoid_relative_lib_imports + - avoid_renaming_method_parameters + - avoid_return_types_on_setters + - avoid_returning_null + - avoid_returning_null_for_future + - avoid_returning_null_for_void + - avoid_returning_this + - avoid_setters_without_getters + - avoid_shadowing_type_parameters + - avoid_single_cascade_in_expression_statements + - avoid_slow_async_io + - avoid_type_to_string + - avoid_types_as_parameter_names + - avoid_types_on_closure_parameters # NEW + - avoid_unnecessary_containers + - avoid_unused_constructor_parameters + - avoid_void_async + - avoid_web_libraries_in_flutter + - await_only_futures + - camel_case_extensions + - camel_case_types + - cancel_subscriptions + - cascade_invocations + - cast_nullable_to_non_nullable + - combinators_ordering # NEW + - comment_references + - conditional_uri_does_not_exist + - constant_identifier_names + - control_flow_in_finally + - curly_braces_in_flow_control_structures + - depend_on_referenced_packages + - deprecated_consistency + - directives_ordering + - discarded_futures # NEW + - empty_catches + - empty_constructor_bodies + - empty_statements + - eol_at_end_of_file + - exhaustive_cases + - file_names + - flutter_style_todos + - hash_and_equals + - implementation_imports + - iterable_contains_unrelated_type + - join_return_with_assignment + - leading_newlines_in_multiline_strings + - library_names + - library_prefixes + - library_private_types_in_public_api + - lines_longer_than_80_chars + - list_remove_unrelated_type + - literal_only_boolean_expressions + - missing_whitespace_between_adjacent_strings + - no_adjacent_strings_in_list + - no_default_cases + - no_duplicate_case_values + - no_leading_underscores_for_library_prefixes + - no_leading_underscores_for_local_identifiers + - no_logic_in_create_state + - no_runtimeType_toString + - non_constant_identifier_names + - noop_primitive_operations + - null_check_on_nullable_type_parameter + - null_closures + - omit_local_variable_types + - one_member_abstracts + - only_throw_errors + - overridden_fields + - package_api_docs + - package_names + - package_prefixed_library_names + - parameter_assignments + - prefer_adjacent_string_concatenation + - prefer_asserts_in_initializer_lists + - prefer_asserts_with_message + - prefer_collection_literals + - prefer_conditional_assignment + - prefer_const_constructors + - prefer_const_constructors_in_immutables + - prefer_const_declarations + - prefer_const_literals_to_create_immutables + - prefer_constructors_over_static_methods + - prefer_contains + - prefer_equal_for_default_values + - prefer_final_fields + - prefer_final_in_for_each + - prefer_final_locals + - prefer_for_elements_to_map_fromIterable + - prefer_function_declarations_over_variables + - prefer_generic_function_type_aliases + - prefer_if_elements_to_conditional_expressions + - prefer_if_null_operators + - prefer_initializing_formals + - prefer_inlined_adds + - prefer_int_literals + - prefer_interpolation_to_compose_strings + - prefer_is_empty + - prefer_is_not_empty + - prefer_is_not_operator + - prefer_iterable_whereType + - prefer_null_aware_method_calls + - prefer_null_aware_operators + - prefer_single_quotes + - prefer_spread_collections + - prefer_typing_uninitialized_variables + - prefer_void_to_null + - provide_deprecation_message + - public_member_api_docs + - recursive_getters + - require_trailing_commas + - secure_pubspec_urls + - sized_box_for_whitespace + - sized_box_shrink_expand + - slash_for_doc_comments + - sort_child_properties_last + - sort_constructors_first + - sort_pub_dependencies + - sort_unnamed_constructors_first + - test_types_in_equals + - throw_in_finally + - tighten_type_of_initializing_formals + - type_annotate_public_apis + - type_init_formals + - unawaited_futures + - unnecessary_await_in_return + - unnecessary_brace_in_string_interps + - unnecessary_const + - unnecessary_constructor_name + - unnecessary_getters_setters + - unnecessary_lambdas + - unnecessary_late + - unnecessary_new + - unnecessary_null_aware_assignments + - unnecessary_null_checks + - unnecessary_null_in_if_null_operators + - unnecessary_nullable_for_final_variable_declarations + - unnecessary_overrides + - unnecessary_parenthesis + - unnecessary_raw_strings + - unnecessary_statements + - unnecessary_string_escapes + - unnecessary_string_interpolations + - unnecessary_this + - unnecessary_to_list_in_spreads # NEW + - unrelated_type_equality_checks + - unsafe_html # NEW + - use_build_context_synchronously + - use_colored_box + - use_decorated_box + - use_enums + - use_full_hex_values_for_flutter_colors + - use_function_type_syntax_for_parameters + - use_if_null_to_convert_nulls_to_bools # NEW + - use_is_even_rather_than_modulo + - use_key_in_widget_constructors + - use_late_for_private_fields_and_variables + - use_named_constants + - use_raw_strings + - use_rethrow_when_possible + - use_setters_to_change_properties + - use_string_buffers + - use_string_in_part_of_directives # NEW + - use_super_parameters + - use_test_throws_matchers # NEW + - use_to_and_as_if_applicable + - valid_regexps + - void_checks diff --git a/lib/analysis_options.yaml b/lib/analysis_options.yaml index 3e5b717..273cb60 100644 --- a/lib/analysis_options.yaml +++ b/lib/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.3.0.2.yaml +include: package:very_good_analysis/analysis_options.3.1.0.yaml diff --git a/lib/very_good_analysis.dart b/lib/very_good_analysis.dart index 842ba99..b0ba776 100644 --- a/lib/very_good_analysis.dart +++ b/lib/very_good_analysis.dart @@ -1,13 +1,3 @@ /// Very Good Dart analyzer settings and best practices /// used internally at [Very Good Ventures](https://verygood.ventures). library very_good_analysis; - -/// Indicates to tools that `Future` is intentionally not `await`-ed. -/// -/// In an `async` context, it is normally expected that all `Future`s are -/// awaited, and that is the basis of the lint `unawaited_futures`. However, -/// there are times where one or more futures are intentionally not awaited. -/// This function may be used to ignore a particular future. It silences the -/// `unawaited_futures` lint. -@Deprecated('Please use unawaited from dart:async.') -void unawaited(Future? future) {} diff --git a/pubspec.yaml b/pubspec.yaml index 44ade98..6c2b76e 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: very_good_analysis -version: 3.0.2 +version: 3.1.0 description: Lint rules for Dart and Flutter used internally at Very Good Ventures. repository: https://github.com/VeryGoodOpenSource/very_good_analysis issue_tracker: https://github.com/VeryGoodOpenSource/very_good_analysis/issues @@ -7,4 +7,4 @@ homepage: https://github.com/VeryGoodOpenSource/very_good_analysis documentation: https://github.com/VeryGoodOpenSource/very_good_analysis environment: - sdk: ">=2.17.0 <3.0.0" + sdk: ">=2.18.0 <3.0.0" From f16bc4410f54eae2fa3bf43042f23f353ff42165 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Wed, 14 Sep 2022 16:38:05 -0500 Subject: [PATCH 5/8] updates --- CHANGELOG.md | 2 -- lib/analysis_options.3.1.0.yaml | 20 +++++++++----------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 95f0349..309c609 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,6 @@ - [avoid_implementing_value_types](https://dart-lang.github.io/linter/lints/avoid_implementing_value_types.html) - [avoid_multiple_declarations_per_line](https://dart-lang.github.io/linter/lints/avoid_multiple_declarations_per_line.html) - [avoid_types_on_closure_parameters](https://dart-lang.github.io/linter/lints/avoid_types_on_closure_parameters.html) - - [combinators_ordering](https://dart-lang.github.io/linter/lints/combinators_ordering.html) - [depend_on_referenced_packages](https://dart-lang.github.io/linter/lints/depend_on_referenced_packages.html) - [discarded_futures](https://dart-lang.github.io/linter/lints/discarded_futures.html) - [no_leading_underscores_for_library_prefixes](https://dart-lang.github.io/linter/lints/no_leading_underscores_for_library_prefixes.html) @@ -13,7 +12,6 @@ - [unnecessary_to_list_in_spreads](https://dart-lang.github.io/linter/lints/unnecessary_to_list_in_spreads.html) - [unsafe_html](https://dart-lang.github.io/linter/lints/unsafe_html.html) - [use_if_null_to_convert_nulls_to_bools](https://dart-lang.github.io/linter/lints/use_if_null_to_convert_nulls_to_bools.html) - - [use_string_in_part_of_directives](https://dart-lang.github.io/linter/lints/use_string_in_part_of_directives.html) - [use_test_throws_matchers](https://dart-lang.github.io/linter/lints/use_test_throws_matchers.html) # 3.0.2 diff --git a/lib/analysis_options.3.1.0.yaml b/lib/analysis_options.3.1.0.yaml index 703df08..61393e8 100644 --- a/lib/analysis_options.3.1.0.yaml +++ b/lib/analysis_options.3.1.0.yaml @@ -27,12 +27,12 @@ linter: - avoid_equals_and_hash_code_on_mutable_classes - avoid_escaping_inner_quotes - avoid_field_initializers_in_const_classes - - avoid_final_parameters # NEW + - avoid_final_parameters - avoid_function_literals_in_foreach_calls - - avoid_implementing_value_types # NEW + - avoid_implementing_value_types - avoid_init_to_null - avoid_js_rounded_ints - - avoid_multiple_declarations_per_line # NEW + - avoid_multiple_declarations_per_line - avoid_null_checks_in_equality_operators - avoid_positional_boolean_parameters - avoid_print @@ -51,7 +51,7 @@ linter: - avoid_slow_async_io - avoid_type_to_string - avoid_types_as_parameter_names - - avoid_types_on_closure_parameters # NEW + - avoid_types_on_closure_parameters - avoid_unnecessary_containers - avoid_unused_constructor_parameters - avoid_void_async @@ -62,7 +62,6 @@ linter: - cancel_subscriptions - cascade_invocations - cast_nullable_to_non_nullable - - combinators_ordering # NEW - comment_references - conditional_uri_does_not_exist - constant_identifier_names @@ -71,7 +70,7 @@ linter: - depend_on_referenced_packages - deprecated_consistency - directives_ordering - - discarded_futures # NEW + - discarded_futures - empty_catches - empty_constructor_bodies - empty_statements @@ -181,16 +180,16 @@ linter: - unnecessary_string_escapes - unnecessary_string_interpolations - unnecessary_this - - unnecessary_to_list_in_spreads # NEW + - unnecessary_to_list_in_spreads - unrelated_type_equality_checks - - unsafe_html # NEW + - unsafe_html - use_build_context_synchronously - use_colored_box - use_decorated_box - use_enums - use_full_hex_values_for_flutter_colors - use_function_type_syntax_for_parameters - - use_if_null_to_convert_nulls_to_bools # NEW + - use_if_null_to_convert_nulls_to_bools - use_is_even_rather_than_modulo - use_key_in_widget_constructors - use_late_for_private_fields_and_variables @@ -199,9 +198,8 @@ linter: - use_rethrow_when_possible - use_setters_to_change_properties - use_string_buffers - - use_string_in_part_of_directives # NEW - use_super_parameters - - use_test_throws_matchers # NEW + - use_test_throws_matchers - use_to_and_as_if_applicable - valid_regexps - void_checks From 0a50ee82f89d039e4c722d3d4b2eb6cc45a3a55e Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Thu, 15 Sep 2022 10:54:40 -0500 Subject: [PATCH 6/8] more adjustments --- CHANGELOG.md | 2 -- lib/analysis_options.3.1.0.yaml | 2 -- 2 files changed, 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 309c609..e691d53 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,9 +2,7 @@ - feat: additional lint rules: - [avoid_final_parameters](https://dart-lang.github.io/linter/lints/avoid_final_parameters.html) - - [avoid_implementing_value_types](https://dart-lang.github.io/linter/lints/avoid_implementing_value_types.html) - [avoid_multiple_declarations_per_line](https://dart-lang.github.io/linter/lints/avoid_multiple_declarations_per_line.html) - - [avoid_types_on_closure_parameters](https://dart-lang.github.io/linter/lints/avoid_types_on_closure_parameters.html) - [depend_on_referenced_packages](https://dart-lang.github.io/linter/lints/depend_on_referenced_packages.html) - [discarded_futures](https://dart-lang.github.io/linter/lints/discarded_futures.html) - [no_leading_underscores_for_library_prefixes](https://dart-lang.github.io/linter/lints/no_leading_underscores_for_library_prefixes.html) diff --git a/lib/analysis_options.3.1.0.yaml b/lib/analysis_options.3.1.0.yaml index 61393e8..8e7f76e 100644 --- a/lib/analysis_options.3.1.0.yaml +++ b/lib/analysis_options.3.1.0.yaml @@ -29,7 +29,6 @@ linter: - avoid_field_initializers_in_const_classes - avoid_final_parameters - avoid_function_literals_in_foreach_calls - - avoid_implementing_value_types - avoid_init_to_null - avoid_js_rounded_ints - avoid_multiple_declarations_per_line @@ -51,7 +50,6 @@ linter: - avoid_slow_async_io - avoid_type_to_string - avoid_types_as_parameter_names - - avoid_types_on_closure_parameters - avoid_unnecessary_containers - avoid_unused_constructor_parameters - avoid_void_async From 1cd11c8c0b3a5de785b8ff105bc917d0ec5ef8bb Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Thu, 15 Sep 2022 11:25:54 -0500 Subject: [PATCH 7/8] remove more rules --- CHANGELOG.md | 2 -- lib/analysis_options.3.1.0.yaml | 2 -- 2 files changed, 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e691d53..132a698 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,11 +4,9 @@ - [avoid_final_parameters](https://dart-lang.github.io/linter/lints/avoid_final_parameters.html) - [avoid_multiple_declarations_per_line](https://dart-lang.github.io/linter/lints/avoid_multiple_declarations_per_line.html) - [depend_on_referenced_packages](https://dart-lang.github.io/linter/lints/depend_on_referenced_packages.html) - - [discarded_futures](https://dart-lang.github.io/linter/lints/discarded_futures.html) - [no_leading_underscores_for_library_prefixes](https://dart-lang.github.io/linter/lints/no_leading_underscores_for_library_prefixes.html) - [no_leading_underscores_for_local_identifiers](https://dart-lang.github.io/linter/lints/no_leading_underscores_for_local_identifiers.html) - [unnecessary_to_list_in_spreads](https://dart-lang.github.io/linter/lints/unnecessary_to_list_in_spreads.html) - - [unsafe_html](https://dart-lang.github.io/linter/lints/unsafe_html.html) - [use_if_null_to_convert_nulls_to_bools](https://dart-lang.github.io/linter/lints/use_if_null_to_convert_nulls_to_bools.html) - [use_test_throws_matchers](https://dart-lang.github.io/linter/lints/use_test_throws_matchers.html) diff --git a/lib/analysis_options.3.1.0.yaml b/lib/analysis_options.3.1.0.yaml index 8e7f76e..fe3007d 100644 --- a/lib/analysis_options.3.1.0.yaml +++ b/lib/analysis_options.3.1.0.yaml @@ -68,7 +68,6 @@ linter: - depend_on_referenced_packages - deprecated_consistency - directives_ordering - - discarded_futures - empty_catches - empty_constructor_bodies - empty_statements @@ -180,7 +179,6 @@ linter: - unnecessary_this - unnecessary_to_list_in_spreads - unrelated_type_equality_checks - - unsafe_html - use_build_context_synchronously - use_colored_box - use_decorated_box From 07c9a117fbdf85e3458c82cb22d75407c0aceaba Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Mon, 19 Sep 2022 11:13:18 -0500 Subject: [PATCH 8/8] update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 132a698..aa0c0a8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ # 3.1.0 +- **BREAKING** refactor: remove deprecated `unawaited` (use `unawaited` from `dart:async` instead). - feat: additional lint rules: - [avoid_final_parameters](https://dart-lang.github.io/linter/lints/avoid_final_parameters.html) - [avoid_multiple_declarations_per_line](https://dart-lang.github.io/linter/lints/avoid_multiple_declarations_per_line.html)