Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove NumericId feature #526

Merged
merged 1 commit into from
May 23, 2022
Merged

remove NumericId feature #526

merged 1 commit into from
May 23, 2022

Conversation

SimonCropp
Copy link
Member

Decided this was a bad idea since it often incorrectly conflates matching ids that should not be correlated

@SimonCropp SimonCropp added this to the 17.0.0 milestone May 23, 2022
@SimonCropp SimonCropp merged commit b77780b into main May 23, 2022
@SimonCropp SimonCropp deleted the remove-NumericId-feature branch May 23, 2022 04:26
steverichey added a commit to corgibytes/freshli-lib that referenced this pull request Sep 6, 2022
ModifySerialization removed: VerifyTests/Verify#533
DontScrubNumericIds removed: VerifyTests/Verify#526
@chrismcv
Copy link

Hi,
Have just upgraded to this version, and found that all our snapshots are failing because of this change. I can see from the diff that there is no way to opt back into the feature.

As we have int Id fields, I'm wondering what the recommendation for handling parallel integration tests is. (Where each arrange step is e.g. inserting into a Client table, and then snapshot an API response containing that Client record)

Thanks
Chris

@SimonCropp
Copy link
Member Author

As we have int Id fields, I'm wondering what the recommendation for handling parallel integration tests is. (Where each arrange step is e.g. inserting into a Client table, and then snapshot an API response containing that Client record)

can u share a minimal repro as a test in a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants