Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate mount point after invoking make install #5599

Closed
rawlingsr opened this issue Feb 22, 2022 · 2 comments
Closed

Duplicate mount point after invoking make install #5599

rawlingsr opened this issue Feb 22, 2022 · 2 comments

Comments

@rawlingsr
Copy link

rawlingsr commented Feb 22, 2022

Podman is the recommended build tool, but using it, instead of docker, results in error during compilation. When using the official build instructions from proton 7.0, the a make file invokes podman or docker with a duplicate mount parameter. Docker is fine with this, but podman complains about the duplicate mount destination.

make -j16  -f Makefile -w V=1 VERBOSE=1 NO_NESTED_MAKE=1 CONTAINER=1 
Error: /home/seti/projects/proton: duplicate mount destination
make[1]: *** [Makefile.in:118: container-build] Error 125
make[1]: Leaving directory '/home/seti/projects/proton'
make: *** [Makefile.in:32: nested_make] Error 2

The podman developers consider the same mount point being mentioned twice in the same invocation to be a bug in whatever script or individual is invoking podman.

Repro steps:

  1. Install Podman, but not docker.
  2. Navigate to proton root directory.
  3. invoke ./configure.sh
  4. invoke make install
  5. Observe that the error included above appears.
    I have tried this on Arch and on Fedora, with identical results.

An example commit of one way this might be resolved can be found here:
rawlingsr@e4cd181

@rawlingsr
Copy link
Author

Welp. If I had read all the build instructions more carefully I'd have seen that a separate build directory is recommended. Maybe the instructions could mention creating a parent folder before cloning proton, or something like that.

@ivyl
Copy link
Collaborator

ivyl commented Mar 1, 2022

I'll add an error for the case when ./configure is invoked from the same top level directory + see what we can improve about the README. Thanks for the feedback :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants