Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/mock_vws/test_query.py::TestMaximumImageFileSize::test_png[Real Vuforia] FAILED #837

Closed
adamtheturtle opened this issue Dec 31, 2020 · 5 comments · Fixed by #882
Closed

tests/mock_vws/test_query.py::TestMaximumImageFileSize::test_png[Real Vuforia] FAILED #837

adamtheturtle opened this issue Dec 31, 2020 · 5 comments · Fixed by #882

Comments

@adamtheturtle
Copy link
Member

See https://github.com/VWS-Python/vws-python-mock/runs/1628674699?check_suite_focus=true

        with pytest.raises(requests.exceptions.ConnectionError):
82
>           query(
83
                vuforia_database=vuforia_database,
84
                body=body,
85
            )
86
E           Failed: DID NOT RAISE <class 'requests.exceptions.ConnectionError'>
@adamtheturtle
Copy link
Member Author

On GitHub actions we get 413 Request Entity Too Large with the following content:

'<html>\r\n<head><title>413 Request Entity Too Large</title></head>\r\n<body bgcolor="white">\r\n<center><h1>413 Request Entity Too Large</h1></center>\r\n<hr><center>nginx</center>\r\n</body>\r\n</html>\r\n'

I am yet to figure out what is different between CI and my local machine where everything passes.

@adamtheturtle
Copy link
Member Author

The test fails on my Mac in an Ubuntu container.

@adamtheturtle
Copy link
Member Author

Next step: Try the request without requests.

@adamtheturtle
Copy link
Member Author

Next step also: Create a minimal reproducible script which displays different behaviour on macOS vs Linux.

@adamtheturtle
Copy link
Member Author

SOLVED!

The original test was really just testing a bug in urllib3 which was fixed in version 1.26.0 with urllib3/urllib3#1524.

This was referenced Mar 23, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix max file size test failure VWS-Python/vws-python-mock
1 participant
@adamtheturtle