add Currency scalar #375
Merged
add Currency scalar #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svengau I'll take a look at that linter issue :) Awesome work! Thanks for the PR! |
vespertilian
pushed a commit
to vespertilian/graphql-scalars
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #374
For information, when I've commited, I've got the following eslint error:
✖ eslint --fix:
/graphql-scalars/tests/Currency.test.ts
0:0 error Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: tests/Currency.test.ts.
The file must be included in at least one of the projects provided
I found a similar issue here, and it seems the tsconfig.json should include "tests/**/*.ts". Anyway, I may have missed something, so I didn't change the ts config, and just commit with --no-verify