Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver operator equal or greater than #4323

Open
dprevost-LMI opened this issue Jul 21, 2023 · 11 comments
Open

Semver operator equal or greater than #4323

dprevost-LMI opened this issue Jul 21, 2023 · 11 comments

Comments

@dprevost-LMI
Copy link

Describe the feature request

Hey, first, nice job supporting the Semantic versioning operator!

Yes, I know it already exists by doing negate of less than, but would it be easy to provide a precise "equal or greater than" so it is easy to read and choose?

Background

This would help us with clarity and readability since it is way easier to understand "equal or greater than" while "negation of less than" kind of needs a second to revert it in my mind!

Having it would remove some ambiguity and make life easier 😄

Solution suggestions

Under the hood, I guess it simply to do the "negate of less than," and it would remove soo much ambiguity.

Thanks!!

@Nezz
Copy link

Nezz commented Aug 10, 2023

We'd also love to have those operators

@Okhoshi
Copy link

Okhoshi commented Aug 10, 2023

There's also a subtile but important difference between a real "equal or greater than" and "negation of less than", it's the case when the field is missing.

If the field is empty, it can't satisfy "equal or greater than" while it will always satisfy "negation of less than".

@sighphyre
Copy link
Member

Hey folks, this seems like a pretty good thing to have but this isn't likely something that we'll do right now. I've marked this as "maybe layer" so our bot doesn't close the PR, we'll look into it

@ivarconr
Copy link
Member

This would require us to update all server-sdks, edge and proxy first withe the lte and gtw support. The work in each SDK will be straight forward.

In the Node SDK it would simply be to add two more (if clauses here).

@stale
Copy link

stale bot commented Sep 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 25, 2023
@dprevost-LMI
Copy link
Author

Please keep it open!

@stale stale bot removed the stale label Sep 25, 2023
@stale
Copy link

stale bot commented Oct 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 28, 2023
@dprevost-LMI
Copy link
Author

Please consider doing so since it should be simple and make life so much easier and minimize mistaken

@stale stale bot removed the stale label Oct 30, 2023
@dprevost-LMI
Copy link
Author

dprevost-LMI commented Nov 24, 2023

An experienced developer just asked me that he was not finding the greater than and had to explain what to use. If only things could be clear 😄

@Nezz
Copy link

Nezz commented Dec 5, 2023

This would require us to update all server-sdks, edge and proxy first withe the lte and gtw support. The work in each SDK will be straight forward.

@ivarconr I wonder if the web UI of unleash could translate "GTE" into "not LT" when it sends the feature configuration to the SDK? That way this functionality could be added without requiring SDK updates.

@sighphyre
Copy link
Member

Hey folks, I see lots of interest in this one. Apologies for our bot closing this, I've put a pinned label on this, hopefully that should keep the bot at bay!

We're working on an architecture change that should make this much easier to implement but it's a fairly large project. We haven't forgotten about this, there's just a bit of ground work that needs to be done to make this kind of change easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

5 participants