Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure increment_var value is a Number #5435

Merged
merged 1 commit into from Sep 8, 2022

Conversation

watsonian
Copy link
Contributor

@watsonian watsonian commented Sep 6, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #4965
License MIT

This ensures the increment_var value is coerced into a Number before attempting to perform any math operations on it. Doing so solves an issue where when you pass in a PORT variable through the environment rather than through the ecosystem config file, it would be read as a string and incrementing it would append the number to the string rather than actually incrementing it (e.g., 3000 would result in using ports 3000 and 30001).

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2022

CLA assistant check
All committers have signed the CLA.

@Unitech Unitech merged commit 8ef8fd2 into Unitech:development Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants