Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .cjs (common JS) as a viable extension #4662

Merged
merged 1 commit into from Apr 14, 2020

Conversation

Timic3
Copy link
Contributor

@Timic3 Timic3 commented Apr 12, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? n/a
Fixed tickets #4652
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

This pull request fixes the following problem: If you define type: module inside package.json, none of the extensions on config file would work (tried with mjs and js). This happens on pm2 deploy command.

This is merely a temporary solution; it would be nice to support module exports, but due to require being used here, we can't. I believe this happens only on pm2 deploy command.

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2020

CLA assistant check
All committers have signed the CLA.

@Unitech Unitech merged commit 03d0b28 into Unitech:development Apr 14, 2020
@koistya
Copy link

koistya commented Aug 16, 2023

pm2 deploy production doesn't seem to be able find ecosystem.config.cjs in an ESM project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants