Added filters for global envs #4596
Conversation
inerc
commented
Feb 3, 2020
•
inerc
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| License | MIT |
| Doc PR | pm2-hive/pm2-hive.github.io#179 |
The pm2 unstartup will always failed in macos. Because the pm2.*.plist will never been deleted.
commands = [
'launchctl remove ' + launchd_service_name + ' || true',
'rm ' + destination
];
launchctl remove always return no-zero value, so rm in the next will never been executed.
PM2 Serve v2
Fix help message of describe/env command
fix pm2 unstartup fialed in macos
Fix for missing column title
…n pm2 show command
|
Thank you for awesome work! Is it going to be merged any time soon? The |
lib/binaries/CLI.js
Outdated
| @@ -42,6 +42,7 @@ commander.version(pkg.version) | |||
| .option('--env <environment_name>', 'specify which set of environment variables from ecosystem file must be injected') | |||
| .option('-a --update-env', 'force an update of the environment with restart/reload (-a <=> apply)') | |||
| .option('-f --force', 'force actions') | |||
| .option('--filter_env [envs]', 'filter outgoing global values by prefix', function(v, m) { m.push(v); return m;}, []) | |||
There was a problem hiding this comment.
We use includes in the filterEnv function and it checks if the string contains passed substring. So we filter outgoing values by the presence of the provided value in the key.
There was a problem hiding this comment.
I hope that it will be in the release soon....
There was a problem hiding this comment.
@inerc I hope so, my pm2 crashes because of the env variables overflow. Can you change the description above? What about: 'filter out outgoing global values that contain provided strings'?
There was a problem hiding this comment.
Yes, it will be better. I have made changes.
|
|
|
thanks for the work. |
