Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an official permit2 distribution to the npm package registry #216

Open
PaulRBerg opened this issue May 18, 2023 · 0 comments
Open

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented May 18, 2023

There seems to be no official npm package associated with this repository:

https://www.npmjs.com/search?q=%40uniswap%2Fpermit2

Only an @uniswap/permit2-sdk package, but that's a front-end library.

The lack of a Node.js package is not great for:

  • Non-Foundry users, e.g. Hardhat
  • Foundry users who, for whatever reason, prefer to use Node.js's dependency management system over git submodules
  • Projects building on top of Permit2 which want to ship a Node.js package and include permit2 as a peer dependency (e.g. the project I represent, Sablier)

Providing a package should be as simple as adding a basic package.json file, and running npm publish.

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant