test: 💍 Add tests for core #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 51.04% 57.18% +6.13%
==========================================
Files 30 30
Lines 382 383 +1
Branches 9 6 -3
==========================================
+ Hits 195 219 +24
+ Misses 187 164 -23
Continue to review full report at Codecov.
|
andrewrigas
reviewed
Jun 7, 2020
| ("test.yaml", ContentType.Yaml), | ||
| ("test.yml", ContentType.Yaml), | ||
| ("test.json", ContentType.Json), | ||
| ("test.txt", ContentType.Plain) |
There was a problem hiding this comment.
edge cases ? and what about if reads something else ?
There was a problem hiding this comment.
There are 3 types:
- Yaml:
yaml,yml - Json:
json - Others: whatever
| ("event", "json"), | ||
| (Event.ServiceUp("id", "test", Map("key" -> "value")), """{"event":"serviceUp","id":"id","name":"test","metadata":{"key":"value"}}"""), | ||
| (Event.ServiceDown("id"), """{"event":"serviceDown","id":"id"}"""), | ||
| (List(Event.ServiceUp("id", "test", Map("key" -> "value"))), |
There was a problem hiding this comment.
I would say list doesnt have to belog in this set and maybe create another table with list of service up and service down and mixture of both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes #4