Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for v1.6.2 release #1212

Merged
merged 1 commit into from Nov 17, 2022
Merged

prepare for v1.6.2 release #1212

merged 1 commit into from Nov 17, 2022

Conversation

jswhit
Copy link
Collaborator

@jswhit jswhit commented Nov 13, 2022

No description provided.

@jswhit
Copy link
Collaborator Author

jswhit commented Nov 15, 2022

this release is needed to fix the serious bug (PR #1209) that prevents compilation with netcdf-c < 4.9.0. New wheels for macosx and linux are created at https://github.com/MacPython/netcdf4-python-wheels/releases/tag/v1.6.2rel. @ocefpaf could you create a windows wheel for the v1.6.2rel branch?

@ocefpaf
Copy link
Contributor

ocefpaf commented Nov 15, 2022

@ocefpaf could you create a windows wheel for the v1.6.2rel branch?

Done in ocefpaf/netcdf4-win-wheels#7

Artifacts can be downloaded here: https://github.com/ocefpaf/netcdf4-win-wheels/actions/runs/3470462639

BTW, I don't mind doing this but we need to increase the bus factor on building Windows wheels.
I'd be happy to add you there as a maintainer on the original repo or transfer that it to Unidata. Whatever is easier to maintain.

@jswhit
Copy link
Collaborator Author

jswhit commented Nov 15, 2022

If the long term solution is to build all the wheels with ocefpaf/netcdf4-win-wheels#6, then I think moving it to the Unidata repo is the way to go. @dopplershift what do you think - do you want to wait and try the cibuildwheel approach first?

@ocefpaf
Copy link
Contributor

ocefpaf commented Nov 15, 2022

If the long term solution is to build all the wheels with ocefpaf/netcdf4-win-wheels#6, then I think moving it to the Unidata repo is the way to go.

OK. Meanwhile would you and @dopplershift be OK to be added as owners of the netcdf4-win-wheels too? Just in case there are a few new releases until we sort this out. Updating there is relatively easy, just bump the version and checksum.

@jswhit jswhit merged commit fe1e8ec into master Nov 17, 2022
@jswhit jswhit deleted the v1.6.2rel branch November 17, 2022 00:19
@jswhit jswhit restored the v1.6.2rel branch November 17, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants