Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of pyproject.toml broke mpi parallel builds #1211

Closed
jswhit opened this issue Nov 12, 2022 · 1 comment
Closed

addition of pyproject.toml broke mpi parallel builds #1211

jswhit opened this issue Nov 12, 2022 · 1 comment

Comments

@jswhit
Copy link
Collaborator

jswhit commented Nov 12, 2022

PR #1208 added pyproject.toml and removed the deprecated build_requires. However, since mpi4py.get_include is used when building with MPI parallel support, and mpi4py cannot be included in pyproject.toml (since it has no wheels on pypi), this broke the mpi tests. As a workaround, PR #1210 adds --no-build-isolation to the pip install so that mpi4py can be imported by setup.py.

@ocefpaf
Copy link
Contributor

ocefpaf commented Nov 12, 2022

Ouch! Sorry for not catching that. I'm not sure if there is a better solution, it seems that h5py does the same.

@jswhit jswhit closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants