New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what to do when a variable is sliced with an all False Boolean index array? #1200

Closed

jswhit opened this issue Oct 12, 2022 · 4 comments

Collaborator

jswhit commented Oct 12, 2022

Current behavior:

for a 1D variable an empty array is returned
for multi-dim variables an opaque exception is raised.
for numpy arrays, an empty array is always returned

Two potential solutions:

PR Added more descriptive error message if indexing with all False bool … #1197: always return an exception with a more informative error message
PR return empty array if boolean index array is all False #1198: always silently return an empty array (as numpy does)

Which one do you prefer?

Collaborator Author

jswhit commented Oct 14, 2022

@dopplershift @shoyer any thoughts on this?

Contributor

shoyer commented Oct 14, 2022

Returning the size zero array like NumPy feels like the right thing to do

Member

dopplershift commented Oct 14, 2022

I agree, my lean was towards mirroring NumPy behavior.

Collaborator Author

jswhit commented Oct 14, 2022

thanks - that's my thought as well. I will merge PR #1198 next week if we have no dissenting opinions by then.

jswhit mentioned this issue

Added more descriptive error message if indexing with all False bool … #1197

Closed

jswhit closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment