Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

iOS - Search Results List - Why is There No Heading Level One (h1) #100

Open
jfc3-dol opened this issue Aug 15, 2019 · 9 comments
Open

iOS - Search Results List - Why is There No Heading Level One (h1) #100

jfc3-dol opened this issue Aug 15, 2019 · 9 comments

Comments

@jfc3-dol
Copy link

jfc3-dol commented Aug 15, 2019

Why is there no heading level one (h1) on the Search Results screen? The screen name for the results is a heading level two (h1) but there is no heading level one (jh1) which I would expect to be the text:

  • XYZ Search results for "ABC"

XYZ is the number of results found and ABC is the term searched for.

@jfc3-dol
Copy link
Author

jfc3-dol commented Sep 5, 2019

Thanks for adding the heading of what the person searched for at the top of the main content section.

When the user uses VoiceOver in continuous reading mode (two-finger down swipe) VoiceOver reads the test '10 search terms for "test"' as one item and not as a heading. But if the user swipes with one finger, it reads it as five items and each as a heading level one (h1). First, if read the number, then the text "search results for". Followed by the first quote, the search term, and then the last quote each as a heading level one (h1).

Not sure why that is happening.

@KyleLivingstonDOL
Copy link

ZTI, can you please address alongside the other Search results issue (I believe it is #99)

@jfc3-dol
Copy link
Author

@harpreetsdev @pbhatt17 @Abychalil

Now there are two heading level one (h1) items. One for the word "Search" that is there on the page before you search and then another one with the number of results for the word/term a person searched about. The second one might make sense to be a heading level two (h2), and the pages headings would become a heading level three (h3) without looking at the code.

The following is still happening too.

When the user uses VoiceOver in continuous reading mode (two-finger down swipe) VoiceOver reads the test '10 search terms for "test"' as one item and not as a heading. But if the user swipes with one finger, it reads it as five items and each as a heading level one (h1). First, if read the number, then the text "search results for". Followed by the first quote, the search term, and then the last quote each as a heading level one (h1).

@jfc3-dol
Copy link
Author

There is only one heading level one (h1) now.

When the user uses VoiceOver in continuous reading mode (two-finger down swipe) VoiceOver reads the test '10 search terms for "test"' as one item and not as a heading.

But if the user swipes with one finger, it reads it as five items and each as a heading level two (h2).

@jfc3-dol
Copy link
Author

jfc3-dol commented Jun 8, 2021

@harpreetsdev @pbhatt17 @Abychalil

When the user uses VoiceOver in continuous reading mode (two-finger down swipe), VoiceOver reads the text '10 search terms for "test"' as one item and not as a heading. VoiceOver also reads the text "Search" as plain text and not as a heading level one (h1) as expected.

But if the user swipes with one finger, VoiceOver reads text '10 search terms for "test"' as five items and each as a heading level one (h1). I would expect them to be read as one item, which is a heading level two (h2).

Please see the attached screenshot showing the VoiceOver focus ring highlighting the last double-quote because it's reading the items on the line as individual items or groups or items.

ilab - comply chain - ios- search screen - VoiceOver reads 10 search results for text as five items when swipe one item at a time

@pbhatt17
Copy link
Contributor

The fix will be released on 13th August release.

@jfc3-dol
Copy link
Author

@pbhatt17

Thanks, will test once I get the latest version next week.

@jfc3-dol
Copy link
Author

@pbhatt17

After searching using VoiceOver, it starts reading at the top of the page instead of announcing the number of search results it found, such as '10 search terms for "test"'. VoiceOver does read the items as one set of text now as we were working towards.

So going to keep this issue open.

@jfc3-dol
Copy link
Author

While using VoiceOver to search focuses on the search box and does not announce to the user how many results were found as expected. When I move to the search results message, it reads "two heading level two" and not the highlighted text.

I searched for "test", so the search message is '10 search results for "test"'.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants