Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When entry is valid, the admiralty input spacing gets smaller #173

Open
KatiePUX opened this issue Mar 4, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@KatiePUX
Copy link
Collaborator

KatiePUX commented Mar 4, 2024

Describe the bug
If you put a valid entry into the input field the admiralty input invalid spacing gets smaller. This is causing the page to bounce as the user completes a form.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'UKHO data upload' > 'Send a new survey'
  2. Click 'Name of survey' input field, enter 'K'
  3. See error

Expected behavior
Spacing to not change and to be consistent with all input fields in the design system

Screenshots
If applicable, add screenshots to help explain your problem.

image
2.
image

@KatiePUX KatiePUX added the bug Something isn't working label Mar 4, 2024
@ecstaticrainbow
Copy link
Contributor

Spoke to Katie and Luke, to resolve this issue we will remove the reserved space for the input error, this should bring everything closer together and also should fix the bouncing around issue. We are happy with the fact the page will stretch vertically when an error does exist but that is how GDS do it and other design systems. It is also worth checking that the CSS rules are setup correctly for the input error so that it doesn't drag the input around when it shows and doesnt show

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants