fix: strip dangling comma #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
built a separate package with with support for dangling comma, extends and parsing with ts api: https://github.com/dominikg/tsconfck |
|
What do you think about using regex like strip-json-trailing-commas did? It is simple and works in all cases. |
zardoy
suggested changes
Sep 18, 2021
| * | ||
| * implementation heavily inspired by strip-json-comments | ||
| */ | ||
| function stripDanglingComma (jsonString: string) { |
There was a problem hiding this comment.
Suggested change
| function stripDanglingComma (jsonString: string) { | |
| function stripDanglingCommas (jsonString: string) { |
| @@ -185,7 +185,7 @@ export function readFileSync (filename: string): any { | |||
| * Parse `tsconfig.json` file. | |||
| */ | |||
| export function parse (contents: string, filename: string) { | |||
| const data = stripComments(stripBom(contents)) | |||
| const data = stripDanglingComma(stripComments(stripBom(contents))) | |||
There was a problem hiding this comment.
Suggested change
| const data = stripDanglingComma(stripComments(stripBom(contents))) | |
| const data = stripDanglingCommas(stripComments(stripBom(contents))) |
I don't like that idea. a regex to only match dangling commas outside of string values is a lot more involved than the iterative approach taken here. but at the same time i'm no longer invested in this PR, see my comment above mentioning tsconfck. if the maintainers of tsconfig ever turn up here again it's up to them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30
note that package.json needs serious updates.
in it's current state build fails with
the output of
npm auditain't pretty either.I suggest a major update on all fronts and cutting 8.0