Add github actions workflow for testing #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm gonna go ahead and merge this so I can see how speed compares to Travis in other pull requests. Apologies if it's an overreach for me to do this without peer review; I'll undo it if anyone disagrees or if it causes problems. |
blakeembrey
reviewed
Mar 4, 2020
| node: 6 | ||
| typescript: typescript@latest | ||
| - flavor: 2 | ||
| node: 13 |
There was a problem hiding this comment.
FWIW, I usually use stable to avoid incrementing this over time. The earliest and lastest node versions has served me pretty well across the things I maintain.
| - run: npm run build | ||
| - run: npm rm tslint | ||
| - run: npm install ${{ matrix.typescript }} | ||
| - run: npm run test-cov |
There was a problem hiding this comment.
Don't forget to push the coverage info to coveralls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment to see if Github Actions are faster than Travis CI.