Revert "Use file URL for source map paths (#1771)" #1821
Conversation
This reverts commit 599f28b.
Codecov Report
|
|
I have no time for issuing an academic desire that has no real world use case. I forgot to mention that it's found when using c8 with |
|
Time constraints are understandable; I've been very busy myself, so I understand where you're coming from. I think there may be some confusion about my comments. This change broke nyc coverage reports and debugging scenarios. Given the evidence available to me, it looks like this change did more harm than good. So reverting is the most appropriate action. We can always discuss further in the future if/when you or anyone else has the time to investigate. |
|
I totally understand that. Maybe we can try the basename solution in the future. I remember the problem was like, |
|
Yeah I had no luck getting in touch with anyone from nyc. I don't think nyc has any meaningful maintainership. Which is unfortunate, nyc clearly needs a patch to support file URIs. The debugger breakpoints issue, I haven't had time to investigate. I created a ticket #1822 for setting up some sort of automated testing for these things. I have no idea how I'll do it, but I think it will be important. And then perhaps those tests will help us validate the basename solution. I want to thank you again for your contribution, even though we had to revert it. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ts-node](https://typestrong.org/ts-node) ([source](https://github.com/TypeStrong/ts-node)) | devDependencies | patch | [`10.8.1` -> `10.8.2`](https://renovatebot.com/diffs/npm/ts-node/10.8.1/10.8.2) | --- ### Release Notes <details> <summary>TypeStrong/ts-node</summary> ### [`v10.8.2`](https://github.com/TypeStrong/ts-node/releases/tag/v10.8.2) [Compare Source](TypeStrong/ts-node@v10.8.1...v10.8.2) **Fixed** - Revert "Use file URL for source map paths" ([#​1821](TypeStrong/ts-node#1821)) [@​cspotcode](https://github.com/cspotcode) - Fixes [#​1790](TypeStrong/ts-node#1790): ts-node 10.8.1 regression where `nyc` code coverage reports had incorrect paths - Fixes [#​1797](TypeStrong/ts-node#1797): ts-node 10.8.1 regression where breakpoints did not hit in VSCode debugging - Allow JSON imports in node 16.15 and up ([#​1792](TypeStrong/ts-node#1792)) [@​queengooborg](https://github.com/queengooborg) - JSON imports were already supported in v17.5 and up - this change extends support to >=16.15.0,<17.0.0 - These version ranges match vanilla node's support for JSON imports https://github.com/TypeStrong/ts-node/milestone/15?closed=1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1446 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Revert #1771
Fixes #1797
Fixes #1790
@PaperStrike if we choose to implement #1769 in the future, it'll need a bit more work to:
a) prove that we are fixing a real-world use-case, not merely an academic desire to comply with a spec
b) prove that debugging scenarios continue to work. Will likely require automated testing of: