Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test combining node flags with ts-node entrypoint and flags in process.execArgv #1657

Closed
cspotcode opened this issue Feb 23, 2022 · 0 comments · Fixed by #1658
Closed

Test combining node flags with ts-node entrypoint and flags in process.execArgv #1657

cspotcode opened this issue Feb 23, 2022 · 0 comments · Fixed by #1658
Labels
bug
Milestone
10.6.0

Comments

@cspotcode
Copy link
Collaborator

cspotcode commented Feb 23, 2022 •
edited

Pretty sure we have a bug in our execArgv logic. It works only if there are not any other node flags in the execArgv array.

Impact for users:

This affects child_process.fork(), since it uses execArgv to create a similar child runtime.
For example, child_process.fork() fails if node is launched node --no-warnings ./node_modules/ts-node/dist/bin ./index.ts
With the fix, child_process.fork() will automatically preserve node flags and ts-node hooks

To test, create a script that spawns a child that spawns a grandchild. In the grandchild, inspect process.execArgv and process.argv

Run it like this:

node --no-warnings ./dist/bin.js --cwd-mode ./spawner.js

--no-warnings can be any node flag that is not understood by ts-node. --cwd-mode can be any ts-node flag that is not understood by node.

The bug is that we're prepending our modifications to the execArgv array; we should be appending them instead.
@cspotcode cspotcode added the bug label Feb 23, 2022
@cspotcode cspotcode mentioned this issue Feb 23, 2022
Merged
@cspotcode cspotcode added this to the 10.6.0 or 10.5.1 milestone Feb 23, 2022
cspotcode added a commit that referenced this issue Feb 23, 2022
@cspotcode
Fix #1657: bug where node flags were not correctly preserved in `exec…
7025abf 
…Argv` (#1658)

* Fix bug

* Fix for windows
@sync-by-unito sync-by-unito bot mentioned this issue Mar 1, 2022
Closed
@cspotcode cspotcode mentioned this issue Mar 7, 2022
Closed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this issue Mar 8, 2022
Update dependency ts-node to v10.6.0 (#1195)
1f77138 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-node](https://typestrong.org/ts-node) ([source](https://github.com/TypeStrong/ts-node)) | devDependencies | minor | [`10.5.0` -> `10.6.0`](https://renovatebot.com/diffs/npm/ts-node/10.5.0/10.6.0) |

---

### Release Notes

<details>
<summary>TypeStrong/ts-node</summary>

### [`v10.6.0`](https://github.com/TypeStrong/ts-node/releases/v10.6.0)

[Compare Source](TypeStrong/ts-node@v10.5.0...v10.6.0)

Questions about this release? Ask in the official discussion thread: [#&#8203;1666](TypeStrong/ts-node#1666)

**Added**

-   Adds workaround for extensionless entrypoints with ESM loader ([#&#8203;1649](TypeStrong/ts-node#1649), [#&#8203;1654](TypeStrong/ts-node#1654))
    -   You can now combine tools such as `mocha` with `--loader ts-node/esm`, where previously node would throw `[ERR_UNKNOWN_FILE_EXTENSION]`
    -   node has a bug where combining `--loader` with an extensionless entrypoint causes this error [nodejs/node#&#8203;33226](nodejs/node#33226)
    -   Some tools, for example `mocha`, have an extensionless entrypoint. ([source](https://github.com/mochajs/mocha/blob/547ffd73535088322579d3d2026432112eae3d4b/package.json#L37), [source](https://github.com/mochajs/mocha/blob/547ffd73535088322579d3d2026432112eae3d4b/bin/mocha))
    -   Combining `NODE_OPTIONS=--loader ts-node/esm` with these tools causes this error.  [mochajs/mocha#&#8203;4645](mochajs/mocha#4645)
    -   node intends to fix this bug in a future release: [nodejs/node#&#8203;41711](nodejs/node#41711)
    -   In the interim, we have implemented a workaround in ts-node.
-   Adds support for target "ES2022" in `moduleTypes` overrides ([#&#8203;1650](TypeStrong/ts-node#1650))

**Fixed**

-   Fixed bug where `--swc` and other third-party transpilers did not respect `moduleTypes` overrides ([#&#8203;1651](TypeStrong/ts-node#1651), [#&#8203;1652](TypeStrong/ts-node#1652), [#&#8203;1660](TypeStrong/ts-node#1660))
-   Fixed bug where node flags were not preserved correctly in `process.execArgv` ([#&#8203;1657](TypeStrong/ts-node#1657), [#&#8203;1658](TypeStrong/ts-node#1658))
    -   This affected `child_process.fork()`, since it uses `process.execArgv` to create a similar child runtime.
    -   With this fix, `child_process.fork()` will preserve both node flags and `ts-node` hooks.
-   Fixed compatibility TypeScript 4.7's API changes ([#&#8203;1647](TypeStrong/ts-node#1647), [#&#8203;1648](TypeStrong/ts-node#1648))

https://github.com/TypeStrong/ts-node/milestone/9

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1195
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
10.6.0
Development

Successfully merging a pull request may close this issue.

Fix #1657: bug where node flags were not correctly preserved in execArgv TypeStrong/ts-node
1 participant
@cspotcode