Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1647 #1648

Merged
merged 3 commits into from Feb 19, 2022
Merged

Fix #1647 #1648

merged 3 commits into from Feb 19, 2022

Conversation

cspotcode
Copy link
Collaborator

Fixes #1647

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #1648 (9f789d0) into main (abc616e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/index.ts 77.90% <100.00%> (ø)
src/resolver-functions.ts 86.00% <100.00%> (+1.55%) ⬆️

@cspotcode cspotcode added this to the 10.6.0 or 10.5.1 milestone Feb 19, 2022
@cspotcode cspotcode merged commit 63a2f83 into main Feb 19, 2022
@cspotcode cspotcode deleted the issue-1647 branch February 19, 2022 05:33
@johnnyreilly
Copy link
Member

thanks for this @cspotcode - may well try and make use of the code here to address the same issue in ts-loader. Should you discover issues with the approach you've adopted, it'd be awesome if you could share them here (I'm assuming there aren't, but good to mention just in case 😄 )

TypeStrong/ts-loader#1421

@cspotcode
Copy link
Collaborator Author

@johnnyreilly definitely, yeah I'll let you know if anything breaks.

I'm not sure there's a strong reason to share code in this case. But if there is anything you want to share in the future, I recently got access to the @typestrong scope on npm. I requested access for something else -- @typestrong/ts-mockito -- but we could also use it for any shared types or helpers or whatnot.

@johnnyreilly
Copy link
Member

Nice! Yeah in my PR I'm doing a little copy pasta from your implementation, but right now it's pretty minimal.

That's definitely a useful tool to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API break notification: crash in resolveTypeReferenceDirective
2 participants