Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fs (cache/tracing) layer into self-contained API #1161

Open
cspotcode opened this issue Nov 22, 2020 · 2 comments · May be fixed by #1518
Open

Refactor fs (cache/tracing) layer into self-contained API #1161

cspotcode opened this issue Nov 22, 2020 · 2 comments · May be fixed by #1518

Comments

@cspotcode
Copy link
Collaborator

We have multiple codepaths which both duplicate FS access code. Additionally, our source-map-support hook touches this FS caching layer.

Refactor into a single fs API which can be instantiated by a factory like createFsLayer() or createFsHost() and then used in all codepaths.

Having this layer may make future features, such as caching, easier to understand. For example, the fs layer can perform all writes into a cache, and all reads from either the cache or real filesystem, whichever is hit first.
@cspotcode cspotcode changed the title Refactor fs (cache/tracing) layer Refactor fs (cache/tracing) layer into self-contained API Nov 22, 2020
@cspotcode cspotcode mentioned this issue Dec 31, 2020
Open
@frank-dspeed
Copy link

Wouldn't it be better to implement something like resolve? i mean pre resolved stuff and do not modify the cache? I think the best place to solve all that issues is the resolve part inside TS we need a way to supply configuration for that and there are hooks implmented in TS for custom reslovers i am not aware if they are exposed or not

But i think its worth investigation into that direction maybe that algins some how with import map support.

@cspotcode
Copy link
Collaborator Author

I think we're talking about different things. For FS caching, necessary to take advantage of --incremental, we need a way to persist what the compiler attempts to write to the filesystem without interfering with normal tsc invocations.

@cspotcode cspotcode mentioned this issue Feb 24, 2021
Open
@cspotcode cspotcode added this to the next milestone May 15, 2021
This was referenced Jun 14, 2021
Closed
Closed
@cspotcode cspotcode modified the milestones: 10.2.0, next, 10.3.0 Aug 8, 2021
@cspotcode cspotcode removed this from the 10.3.0 milestone Oct 10, 2021
@cspotcode cspotcode linked a pull request Oct 16, 2021 that will close this issue
Open
@cspotcode cspotcode linked a pull request Oct 16, 2021 that will close this issue
Refactor fs (cache/tracing) layer into self-contained API #1518
Open
@cspotcode cspotcode mentioned this issue Oct 16, 2021
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor fs (cache/tracing) layer into self-contained API TypeStrong/ts-node
2 participants
@cspotcode @frank-dspeed