Set of extra ignored diagnostics for REPL mode #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
…e annoying diagnostics in the REPL
…stdin] nor [eval]
|
I gave this some more thought; I feel good enabling by default in a minor release. |
cspotcode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1120
Closes #729
Closes #850
Closes #469
Refactors diagnostic-ignoring logic to support per-file filters.
REPL can add a filter which applies only to the REPL's virtual file and removes diagnostics which are annoying in interactive mode. For example, "unreachable code" and "duplicate function declaration"
Also refactors some test macros