Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow typeCheck CLI flag to override transpileOnly tsconfig flag #1142

Merged
merged 1 commit into from Nov 3, 2020

Conversation

cspotcode
Copy link
Collaborator

Fixes #1119

In #1119 we discussed some more ideal solutions, but this fix is simple and unblocks the user.

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #1142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files           7        7           
  Lines         711      711           
  Branches      158      158           
=======================================
  Hits          566      566           
  Misses         89       89           
  Partials       56       56           
Flag Coverage Δ
node_10 76.28% <0.00%> (ø)
node_12_15 76.63% <0.00%> (ø)
node_12_16 76.63% <0.00%> (ø)
node_13 79.32% <0.00%> (ø)
node_14 79.32% <0.00%> (ø)
node_14_13_0 78.19% <0.00%> (ø)
node_15 79.32% <0.00%> (ø)
typescript_2_7 79.18% <0.00%> (ø)
typescript_latest 78.48% <0.00%> (ø)
typescript_next 78.34% <0.00%> (ø)
ubuntu 79.32% <0.00%> (ø)
windows 79.46% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e6e3e...6a707b8. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 1, 2020

Coverage Status

Coverage increased (+0.9%) to 87.097% when pulling 6a707b8 on ab/fix-1119 into c1e6e3e on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag to override a default of transpileOnly
3 participants