Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken tests #1108

Merged
merged 2 commits into from Aug 11, 2020
Merged

fix broken tests #1108

merged 2 commits into from Aug 11, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Aug 11, 2020

Some logic wasn't wrapped in a before() hook so if you used --fgrep then tests would fail. Probably a race condition where another test was installing the require() hooks.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files           7        7           
  Lines         657      657           
  Branches      148      148           
=======================================
  Hits          496      496           
  Misses        107      107           
  Partials       54       54           
Flag Coverage Δ
#node_10 71.96% <ø> (-0.19%) ⬇️
#node_12_15 72.34% <ø> (-0.19%) ⬇️
#node_12_16 72.53% <ø> (ø)
#node_13 75.19% <ø> (ø)
#node_14 75.19% <ø> (ø)
#typescript_2_7 75.03% <ø> (ø)
#typescript_latest 74.27% <ø> (ø)
#typescript_next 74.12% <ø> (ø)
#ubuntu 75.03% <ø> (-0.16%) ⬇️
#windows 75.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91aa85...c637f5e. Read the comment docs.

@cspotcode cspotcode merged commit 77f568d into master Aug 11, 2020
@coveralls
Copy link

coveralls commented Aug 11, 2020

Coverage Status

Coverage increased (+1.0%) to 83.175% when pulling c637f5e on ab/fix-broken-tests into b91aa85 on master.

@cspotcode cspotcode deleted the ab/fix-broken-tests branch August 12, 2020 18:22
@cspotcode cspotcode mentioned this pull request Aug 21, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants