Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE_NO_READLINE support #1090

Merged
merged 5 commits into from Aug 4, 2020
Merged

NODE_NO_READLINE support #1090

merged 5 commits into from Aug 4, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Jul 29, 2020

https://nodejs.org/api/repl.html#repl_using_the_node_js_repl_with_advanced_line_editors

Totally untested; just wanted to jot this down before I forget. EDIT: Does it need tests? If so I'll add then, but it's so minor.
#328

@cspotcode cspotcode marked this pull request as draft July 29, 2020 07:40
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #1090 into master will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
+ Coverage   75.08%   75.20%   +0.12%     
==========================================
  Files           6        6              
  Lines         606      613       +7     
  Branches      141      143       +2     
==========================================
+ Hits          455      461       +6     
  Misses        100      100              
- Partials       51       52       +1     
Flag Coverage Δ
#node_10 71.95% <0.00%> (-0.40%) ⬇️
#node_12_15 72.34% <0.00%> (-0.41%) ⬇️
#node_12_16 72.34% <0.00%> (-0.41%) ⬇️
#node_13 74.87% <0.00%> (+0.12%) ⬆️
#node_14 74.87% <0.00%> (+0.12%) ⬆️
#typescript_2_7 74.71% <0.00%> (+0.12%) ⬆️
#typescript_latest 73.89% <0.00%> (+0.13%) ⬆️
#typescript_next 73.73% <0.00%> (+0.13%) ⬆️
#ubuntu 74.87% <0.00%> (+0.12%) ⬆️
#windows 75.04% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/bin.ts 70.11% <0.00%> (-0.41%) ⬇️
src/index.ts 77.64% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e7896...b65c761. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 29, 2020

Coverage Status

Coverage increased (+1.2%) to 83.163% when pulling b65c761 on ab/node_no_readline into 04e7896 on master.

@cspotcode cspotcode marked this pull request as ready for review July 29, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants