Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] still need to support node 6? #1033

Closed
cspotcode opened this issue May 10, 2020 · 3 comments
Closed

[META] still need to support node 6? #1033

cspotcode opened this issue May 10, 2020 · 3 comments

Comments

@cspotcode
Copy link
Collaborator

@blakeembrey

I'm not opposed to supporting node 6 and/or 8, but I also don't know the history, if any. Did you hear from a bunch of users who were stuck on node 6? I assume that when you initially set up CI tests, node 6 was relevant, and the tests haven't been updated since then.

Node 8 was EOLd in December. If we wanted to make our lives a little easier, we could start supporting node >=10.

@blakeembrey
Copy link
Member

I assume that when you initially set up CI tests, node 6 was relevant, and the tests haven't been updated since then.

Basically this, and bumping it is a major breaking change (as discovered when we accidentally updated yn). We should bump it in the next major version, which can honestly be whenever - just haven't had any breaking change needs yet since I haven't been actively building new features. Feel free to bump whenever you want.

@cspotcode
Copy link
Collaborator Author

cspotcode commented May 10, 2020

Ok, sounds good. Are you ok bumping up to node 10? EDIT nevermind I asked this specifically in my first post. :/ Sounds good!

@cspotcode
Copy link
Collaborator Author

Bumped by #1036 which can be merged whenever we make the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants