Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade most production deps #1237

Merged
merged 4 commits into from Jan 5, 2021
Merged

chore(deps): upgrade most production deps #1237

merged 4 commits into from Jan 5, 2021

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Jan 4, 2021

adjusted chalk import/initialization to new major

adjusted chalk import/initialization to new major
src/instances.ts Outdated Show resolved Hide resolved
@johnnyreilly
Copy link
Member

Awesome. Could you increment the version the package.json and add an entry to the CHANGELOG.md please?

@AviVahl
Copy link
Contributor Author

AviVahl commented Jan 5, 2021

Done. I avoided adding the thanks @<myself> to the changelog. Otherwise, I get flooded with Dependabot notifications including that @. XD

@johnnyreilly
Copy link
Member

I didn't think dependabot read CHANGELOG.md - could be wrong.

It's fine to not have your handle in there if that's the case. Please could you put "thanks Avi Vahl" instead then please? That's human readable and as such I'm fine with it.

@AviVahl
Copy link
Contributor Author

AviVahl commented Jan 5, 2021

Done.

@AviVahl
Copy link
Contributor Author

AviVahl commented Jan 5, 2021

Oh, and Dependabot picks up the release notes from the GitHub releases page. I already got spammed from a contribution to handlebars once, as they credited my handle.

@johnnyreilly
Copy link
Member

Oh, and Dependabot picks up the release notes from the GitHub releases page

Interesting - I would have imagined it used the related commits and the authors there instead. Go figure

@johnnyreilly johnnyreilly merged commit 268bc69 into TypeStrong:master Jan 5, 2021
@AviVahl AviVahl deleted the upgrade-production-deps branch January 5, 2021 17:37
@johnnyreilly
Copy link
Member

Shipped - thanks for the contribution!

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants