Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses existing instance if config file is same as already built solution #1177

Merged
merged 7 commits into from Sep 19, 2020

Conversation

sheetalkamat
Copy link
Contributor

This is another take on #1176 again not sure if this is right approach.

@johnnyreilly
Copy link
Member

Copied over from #1176

This one just shares solution builder and uses program/language service as if its own..

Okay cool. I don't feel strongly about the different approaches; each sounds good! Without having tested it, I'd guess that #1177 may perform slightly better as it's not creating new instances. I haven't tested it and it may be a marginal difference, but maybe #1177 is the way to go.

Do you fancy incrementing the version in the package.json and adding an entry to the CHANGELOG.md on this PR ?

@johnnyreilly johnnyreilly merged commit 95b6fe8 into master Sep 19, 2020
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants