Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 watch not failing on error #1253

Closed
aardvarkk opened this issue Feb 5, 2021 · 3 comments
Closed

Webpack 5 watch not failing on error #1253

aardvarkk opened this issue Feb 5, 2021 · 3 comments
Labels

Comments

@aardvarkk
Copy link

Expected Behaviour

  • Making a file invalid should cause webpack watch compilation to fail
  • I realize I have named this issue exactly like this one, but that issue is marked as resolved as of a few versions ago and yet strange behaviour still seems to persist

Actual Behaviour

  • Webpack watch appears to succeed despite invalid input

Steps to Reproduce the Problem

  • npm i
  • npx webpack watch
    • compilation succeeds
  • edit src/index.ts to uncomment out the trailing { and save
  • notice npx webpack watch runs again and compilation still succeeds
  • stop npx webpack watch
  • run npx webpack watch again and notice that an error now appears

Location of a Minimal Repository that Demonstrates the Issue.

https://github.com/aardvarkk/webpack-ts-loader-issue/tree/main

@appzuka
Copy link
Member

appzuka commented Feb 8, 2021

@aardvarkk, Thanks for reporting this. I did resolve #1204 but then broke it again fixing #1243. Check #1204 for my explanation. I will raise a PR to fix this.

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 17, 2022
@stale
Copy link

stale bot commented Apr 28, 2022

Closing as stale. Please reopen if you'd like to work on this further.

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants