Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecation warnings on webpack@5. #1195

Merged

Conversation

sanex3339
Copy link
Contributor

Fixed #1194

@sanex3339
Copy link
Contributor Author

Don't sure how to test it, especially because previous checks for webpack@5 were without tests.

src/index.ts Outdated Show resolved Hide resolved
src/instances.ts Outdated Show resolved Hide resolved
src/instances.ts Outdated Show resolved Hide resolved
@johnnyreilly
Copy link
Member

johnnyreilly commented Oct 12, 2020

Looks good! I've left some comments / suggestions above. (Essentially the same point three times 😄 ) What do you think?

@sanex3339
Copy link
Contributor Author

Looks good! I've left some comments / suggestions above. (Essentially the same point three times 😄 ) What do you think?

Fixed

@johnnyreilly
Copy link
Member

Could you update the version in the package.json to 8.0.5 and add an entry to the package.json please? If the tests pass we're likely safe to ship.

@sanex3339
Copy link
Contributor Author

Could you update the version in the package.json to 8.0.5 and add an entry to the package.json please? If the tests pass we're likely safe to ship.

57d3fe9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5: deprecation warning [DEP_WEBPACK_MODULE_ERRORS]
2 participants