You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all thank you for working on this plugin and fixing this issue #558
However, I noticed another problem with the plugin v6+
Current behavior
Let's say we have 2 different entry points of webpack config. firstEntry.ts – client bundle secondEntry.ts – server bundle
And we run two parallel npm run watch scripts.
In case of changing something in firstEntry.ts file, checks are triggered in both watch scripts.
Expected behavior
Changing something in firstEntry.ts should only trigger TS check in this particular webpack entry.
P.S. In v.5.2.1 it works as it should. TS checker runs only for the changed entry point.
Steps to reproduce the issue
Open two terminal windows
Run npm run watch:first in first window
Run npm run watch in second window
Notice how change in firstEntry.ts file also triggered check in second terminal window (secondEntry.ts)
It's an intentional behavior - the plug-in tries to mimic tsc as much as it's possible. The changes in v6 that triggers build on unrelated files changes from the webpack perspective fixes watch issues with type-only files. In previous versions if you had type-only file, it was not included in the dependencies set and therefore was not watched.
In general, the issue comes from the fact that TypeScript project have different semantics than webpack project and they are not compatible. The current solution favors TypeScript semantics where project is a set of files that matches pattern from tsconfig file (not dependency graph like in webpack)
First of all thank you for working on this plugin and fixing this issue #558
However, I noticed another problem with the plugin v6+
Current behavior
Let's say we have 2 different entry points of webpack config.
firstEntry.ts
– client bundlesecondEntry.ts
– server bundleAnd we run two parallel
npm run watch
scripts.In case of changing something in
firstEntry.ts
file, checks are triggered in bothwatch
scripts.Expected behavior
Changing something in
firstEntry.ts
should only trigger TS check in this particular webpack entry.P.S. In v.5.2.1 it works as it should. TS checker runs only for the changed entry point.
Steps to reproduce the issue
npm run watch:first
in first windownpm run watch
in second windowfirstEntry.ts
file also triggered check in second terminal window (secondEntry.ts
)Issue reproduction repository
https://github.com/Melzmr/excluded-558
Environment
Now:
Before:
The text was updated successfully, but these errors were encountered: