Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for schema.json #1983

Merged
merged 5 commits into from Jul 6, 2022
Merged

fixes for schema.json #1983

merged 5 commits into from Jul 6, 2022

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Jul 4, 2022 •
edited

there are 3 fixes in this PR:

  1. properly define json files in settings.json so that they don't throw errors in vscode when you open them
  2. add "allowTrailingCommas": true as documented here: Tolerate trailing commas in jsonc format microsoft/vscode#102061 (comment)
  3. lowercase first letter of enum members so that they match the stylization in the docs

Gerrit0
Gerrit0 requested changes Jul 4, 2022
View reviewed changes
.vscode/settings.json Show resolved Hide resolved
scripts/generate_options_schema.js Show resolved Hide resolved
@Zamiell @Gerrit0
Update scripts/generate_options_schema.js
0a8ea14 
Co-authored-by: Gerrit Birkeland <gerrit@gerritbirkeland.com>
@Zamiell
Copy link
Contributor Author

Zamiell commented Jul 6, 2022

re: camelcase
doesn't matter much to me, i'll defer to your judgement

@Zamiell Zamiell requested a review from Gerrit0 July 6, 2022 03:18
@Gerrit0 Gerrit0 merged commit 1004768 into TypeStrong:master Jul 6, 2022
@Zamiell Zamiell deleted the schema branch July 7, 2022 06:04
@Gerrit0 Gerrit0 mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit0 Gerrit0 Gerrit0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zamiell @Gerrit0