Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump marked from 3.0.8 to 4.0.10 #1851

Merged
merged 2 commits into from Jan 18, 2022

Conversation

stefanobaghino-da
Copy link
Contributor

@stefanobaghino-da stefanobaghino-da commented Jan 17, 2022

Attempts at superseding #1844
by bumping to a more recent @types/marked and fixing where breaking
changes happened.

Bumps marked from 3.0.8 to 4.0.10.

Updates at superseding TypeStrong#1844
by bumping to a more recent `@types/marked` and fixing where breaking
changes happened.

Bumps [marked](https://github.com/markedjs/marked) from 3.0.8 to 4.0.10.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v3.0.8...v4.0.10)
stefanobaghino-da added a commit to digital-asset/daml that referenced this pull request Jan 17, 2022
A couple of fixes on top of #12443:
- unpin the node-forge 0.10.0 resolution to remove it from our lockfile
- remove the useless scoped resolution for marked

For the latter, the transitive dependency breaks between 3.x and 4.x so the
problem is not easily solved without `typedoc` maintainers publishing a
fixed version. I opened a PR here: TypeStrong/typedoc#1851

changelog_begin
changelog_end
@stefanobaghino-da
Copy link
Contributor Author

Mmmh, looks like I should fix the lockfile, having a look (apologies, I'm not particularly expert in npm).

@stefanobaghino-da
Copy link
Contributor Author

Mmmh, looks like I should fix the lockfile, having a look (apologies, I'm not particularly expert in npm).

Fixed by d959b71

@Gerrit0 Gerrit0 merged commit 3bc9c78 into TypeStrong:master Jan 18, 2022
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 18, 2022

Thanks!

@stefanobaghino-da stefanobaghino-da deleted the bump-to-marked-4.0.10 branch January 18, 2022 07:32
stefanobaghino-da added a commit to digital-asset/daml that referenced this pull request Jan 18, 2022
A couple of fixes on top of #12443:
- unpin the `self-signed` resolution to remove the transitive dependency
on `node-forge` 0.10.0
- upgrades `typedoc` to 0.22.11 after
TypeStrong/typedoc#1851 got merged to remove the
transitive dependency on `marked` 3.x

changelog_begin
changelog_end
@stefanobaghino-da
Copy link
Contributor Author

Many thanks for accepting the PR and immediately making a new release! 🙇🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants