Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contributing experience #1838

Merged

Conversation

albyrock87
Copy link
Contributor

While trying to contribute to the project I found it very difficult to debug unit tests.
Therefore I created this PR to improve dev-experience

  • speedup tsc using incremental flag (unfortunately ts-node doesn't support incremental flag yet)
  • add Mocha Explorer VSCode extension support

I had to move ts-internal types to a folder to make ts-node compile correctly.

image

- speedup tsc using incremental flag
- add Mocha Explorer VSCode extension support
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 23, 2022

I'm not sure I want to add something that recommends people install extensions whenever they open the project in VSCode... particularly when the description of that extension includes:

In version 1.59, VS Code added an official API and UI for running tests, which provides all the functionality of this extension and more. Therefore this extension is now deprecated. I will keep maintaining it so it will remain usable but I don't plan to add any major new features to it.

Is there a better way of doing this?

Copy link
Collaborator

@Gerrit0 Gerrit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albyrock87
Copy link
Contributor Author

albyrock87 commented Feb 6, 2022

@Gerrit0 I looked at available VSCode Mocha engines and unfortunately no one supports native test API.
The reason for this is that Test Explorer UI extension which is being used by Mocha Test Explorer has a new flag:
https://marketplace.visualstudio.com/items?itemName=hbenl.vscode-test-explorer

You can keep using this extension as before, but you now also have the option to use VS Code's native testing UI instead by setting testExplorer.useNativeTesting to true in your VS Code settings.

So the author of Mocha Test Explorer will not spend more time trying to convert everything to native API.

What we could do, is to force that flag on the workspace settings.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 12, 2022

Thanks for looking into this! Sounds like an opportunity for a new project... in the meantime, this works.

@Gerrit0 Gerrit0 merged commit a6e494f into TypeStrong:master Feb 12, 2022
@albyrock87 albyrock87 deleted the feature/improve-contributing-experience branch February 12, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants