Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output file path and source file path to MarkedPlugin error message #1561

Merged
merged 1 commit into from Apr 3, 2021

Conversation

MasatoMakino
Copy link
Contributor

related : #1557

In this PR, the error message does not show the line number. If there are code blocks in the included external files, it is not possible to get the correct number of lines. Instead of the line number, I have added information about target code block and output file path.

The error messages are formatted with tabs. I have searched in the repository but could not find any example of error message formatting.

@Gerrit0 Gerrit0 merged commit a90deee into TypeStrong:master Apr 3, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 3, 2021

Thanks!

This isn't a perfect fix, since the sources property won't be set if someone uses the --disableSources option, but it's better than what we have today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants