Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.20 inheritedFrom property not set at declaration creation #1527

Closed
jonchardy opened this issue Mar 5, 2021 · 2 comments
Closed

v0.20 inheritedFrom property not set at declaration creation #1527

jonchardy opened this issue Mar 5, 2021 · 2 comments
Labels
bug Functionality does not match expectation

Comments

@jonchardy
Copy link
Contributor

Search terms

inheritedFrom, inherit, inheritance

Expected Behavior

Typedoc v0.20 should properly set Reflection.inheritedFrom for inherited members prior to calling any EVENT_CREATE_DECLARATION listeners. This allows plugins to check inheritance prior to resolving.

Actual Behavior

Reflection.inheritedFrom is not set for inherited members at the time of EVENT_CREATE_DECLARATION. This breaks https://github.com/jonchardy/typedoc-plugin-no-inherit.

Steps to reproduce the bug

See https://github.com/jonchardy/typedoc-inheritedfrom-breaking.

Environment

  • Typedoc version: 0.20.x
  • TypeScript version: 4.2.x
  • Node.js version: 14.15.5
  • OS: Windows 10
@jonchardy jonchardy added the bug Functionality does not match expectation label Mar 5, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 6, 2021

Awww... I knew it was too good to be true that that change hadn't broken anything.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 13, 2021

This is set during EVENT_CREATE_DECLARATION with a fairly high priority, so it should work... I hate all of the code I wrote to make it work though.

This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

2 participants