Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add detecting read-only properties #1268

Merged
merged 1 commit into from
Apr 20, 2020
Merged

feat: Add detecting read-only properties #1268

merged 1 commit into from
Apr 20, 2020

Conversation

Unnvaldr
Copy link
Contributor

@Unnvaldr Unnvaldr commented Apr 13, 2020

Resolves #585

Lack of this feature surprised me, I thought that such an important feature would be here from the beginning. Also I saw previous pull request that wasn't only addressing this issue and is a bit old, so I created* new one from the foundations to make sure it's compatible.

This is my first pull request here, I've left the ability for maintainers to edit this pull request, so I'm open to any suggestions, critic, help etc.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 14, 2020

I'll have to pull this down this weekend and make sure it works, but it looks good at a first pass! Thanks!

@Gerrit0 Gerrit0 merged commit 91644a9 into TypeStrong:master Apr 20, 2020
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 20, 2020

Thanks! I should be able to get a release out this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show in the generated documentation which properties are readonly.
2 participants