Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid iterating over undefined array. #1208

Merged
merged 2 commits into from
Feb 15, 2020
Merged

Avoid iterating over undefined array. #1208

merged 2 commits into from
Feb 15, 2020

Conversation

zslayton
Copy link
Contributor

Fixes #1207.

I've been using this patch to unblock my project, but I'm unsure if additional logic is needed in the case that typeToInheritFrom.symbol is defined but typeToInheritFrom.symbol.declarations is not.

@Gerrit0 Gerrit0 merged commit 91cfa1b into TypeStrong:master Feb 15, 2020
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 15, 2020

Thanks! I'll put out a patch release later this weekend with these changes.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 16, 2020

Released in 0.16.10

@zslayton zslayton mentioned this pull request Feb 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mixins cause: TypeError: Cannot read property 'forEach' of undefined
2 participants
@zslayton @Gerrit0