Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to TypeScript 3.7 #1129

Merged
merged 6 commits into from
Nov 9, 2019
Merged

Upgrade to TypeScript 3.7 #1129

merged 6 commits into from
Nov 9, 2019

Conversation

pmconne
Copy link
Contributor

@pmconne pmconne commented Nov 7, 2019

TypeScript 3.7 introduces assertion functions which previous versions of tsc cannot compile.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 8, 2019

While not technically wrong, it's kind of weird to convert the return type to void. I'd like to look into this to see if it would be an easy fix before merging, should have enough time this weekend.

This was referenced Nov 8, 2019
Closed
Closed
@Gerrit0
Upgrade the rest of the dependencies for good measure
8d43d78
@Gerrit0
Upgrade nyc to beta
d63977a 
Gets around istanbuljs/nyc#1205 breaking on Windows with Node 12.
@Gerrit0
Add type predicate converter
426f50c 
Also add a few more tests + rebuild specs again.
@Gerrit0
Keep tests passing
90ae847 
Temporarily switch to @gerrit0/typedoc-default-themes to keep tests passing
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 9, 2019 •
edited

Turns out that wasn't too difficult after all, thanks for the PR! I've reached out to Anthony about getting a 0.15.1 release with this in it. Just waiting for Travis to pass to merge.

If you need the changes now, I keep @gerrit0/typedoc up to date with master here (whenever bugs are fixed / features added, I don't bother with new releases if nothing user-facing changes), so it will have these changes in an hour or so. Edit: Available with 0.15.9

@Gerrit0 Gerrit0 merged commit 5704bf5 into TypeStrong:master Nov 9, 2019
@hasezoey hasezoey mentioned this pull request Nov 11, 2019
Closed
@pmconne pmconne deleted the typescript-3.7 branch November 11, 2019 18:54
blakeembrey
blakeembrey reviewed Nov 12, 2019
View reviewed changes
package.json
"lodash": "^4.17.15",
"marked": "^0.7.0",
"minimatch": "^3.0.0",
"progress": "^2.0.3",
"shelljs": "^0.8.3",
"typedoc-default-themes": "^0.6.0",
"typescript": "3.6.x"
"@gerrit0/typedoc-default-themes": "^0.6.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be reverted once you publish to the main namespace?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I kept it here for now so that tests would keep passing. It should be reverted before a new theme version is published.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has now been reverted

@blink1073 blink1073 mentioned this pull request Nov 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeembrey blakeembrey blakeembrey left review comments

@Gerrit0 Gerrit0 Gerrit0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmconne @Gerrit0 @blakeembrey