Improve output for computed property names #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rbuckton! Could you add a simple test case? It can be in one of the existing files. |
|
It would also be great if there was a way to get the original property name from the compiler API, instead of needing to construct it ourselves, but I'm not sure if that capability exists. |
|
Thanks! I looked into getting the original name from the API, but it was more complicated than just computing the symbol name ourselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the documentation for
[Symbol.iterator](): Iterator<string>reports the property name as__@iterator, and other computed property names are reported as__computed. This improves the name generated for computed properties where possible.