Clarify MarchingSquares.js license #1993
Merged
+65
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaumZeit
reviewed
Jan 5, 2021
| * - allows you to distribute UNMODIFIED VERSIONS of MarchingSquaresJS under any | ||
| * license as long as this license notice is included | ||
| * - enables you to keep the source code of your program that uses MarchingSquaresJS | ||
| * disclosed |
There was a problem hiding this comment.
should be 'undisclosed' (see RaumZeit/MarchingSquares.js#25)
RaumZeit
reviewed
Jan 5, 2021
| * - allows you to distribute UNMODIFIED VERSIONS of MarchingSquaresJS under any | ||
| * license as long as this license notice is included | ||
| * - enables you to keep the source code of your program that uses MarchingSquaresJS | ||
| * disclosed |
There was a problem hiding this comment.
should be 'undisclosed' (see RaumZeit/MarchingSquares.js#25)
|
Looks good to me @mfedderly - I think there is enough material that should come up on keyword searches in this repo which point to the history of how this came about so I think it's good to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bit of confusion about the license on the MarchingSquares code. In order to make it clearer that this particular code is compatible with Turf's chosen MIT license, I went ahead and copied the entire license block from the source repo and put it inline to make things clearer for the next person that comes along.
Related original discussion: RaumZeit/MarchingSquares.js#3
@stebogit @RaumZeit @rowanwins FYSA
There's also an unrelated small yarn.lock update that somehow wasn't caught by the build system.