Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with emoji icons #55

Merged
merged 1 commit into from Jun 26, 2019
Merged

with emoji icons #55

merged 1 commit into from Jun 26, 2019

Conversation

a-x-
Copy link
Contributor

@a-x- a-x- commented Jun 26, 2019

closes #54

Great UX coming us. User can understand what is happened w/o focusing notification now.
Well known icons deal with our primitive and fast part of brain directly w/o extra distraction to reading

We can be confused when error caused, but we did not read the text sometimes

@a-x- a-x- changed the title with --emoji icons with emoji icons Jun 26, 2019
Copy link
Owner

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Turbo87 Turbo87 merged commit 1563c71 into Turbo87:master Jun 26, 2019
@a-x- a-x- deleted the patch-1 branch June 26, 2019 14:37
@a-x-
Copy link
Contributor Author

a-x- commented Jun 26, 2019

Thank you much!
Can you release a version also? =)

@Turbo87
Copy link
Owner

Turbo87 commented Jun 27, 2019

released as v1.8.0 a few seconds ago

@@ -45,7 +45,7 @@ WebpackNotifierPlugin.prototype.compileMessage = function(stats) {

} else if (!this.lastBuildSucceeded || this.options.alwaysNotify) {
this.lastBuildSucceeded = true;
return 'Build successful';
return (hasEmoji ? '✅ ' : '') + 'Build successful';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses hasEmoji before it's assigned, so it'll always be false.

@Gvozd
Copy link
Collaborator

Gvozd commented Nov 15, 2020

@mAAdhaTTah fixed at 1.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No one want to read text on notifications. Let's add opt-in emoji icons
4 participants