Fix problem with enl extensions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Mar 23, 2018
tests/igc/test_reader.py
Outdated
| processed_b_record = LowLevelReader.process_B_record(decoded_b_record, fix_record_extensions) | ||
|
|
||
| assert 'ENL' in processed_b_record | ||
| assert expected_enl == processed_b_record['ENL'] |
There was a problem hiding this comment.
we should be asserting against a constant here to make sure we don't screw up our own test logic here. if I read correct 00128 and 00196 are the two altitudes and after that are the extensions. the first extension is FXA with 006 and ENL is second with 001 which is 1 as an integer.
in other words, I think this should just be:
assert processed_b_record['ENL'] == 1
|
oh, looks like we have a small merge conflict now 😞 |
|
Any action from me needed? |
|
nope, just needed to wait until CI passed and then forgot to check again 🙈 |
|
I know in gitlab there’s an automated merge when pipeline succeeds functionality. Would be nice if github has this as well |
|
totally, yeah... 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current IGC reader does not correctly parse the record extensions. This branch exposes this bug and fixes it.